[GitHub] [druid] syacobovitz commented on a change in pull request #12198: Added url support and change the way metrics are written

[GitBox <gi...@apache.org>]

syacobovitz commented on a change in pull request #12198:
URL: https://github.com/apache/druid/pull/12198#discussion_r815618164



##########
File path: extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
##########
@@ -77,12 +80,28 @@ public void start()
       } else {
         log.error("HTTPServer is already started");
       }
-    } else if (strategy.equals(PrometheusEmitterConfig.Strategy.pushgateway)) {
-      pushGateway = new PushGateway(config.getPushGatewayAddress());
+    } else if (strategy.equals(PrometheusEmitterConfig.Strategy.pushgateway) && config.getPushGatewayAddress() != null) {

Review comment:
       I implemented your comment, thanks for the advice




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org