You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2016/06/27 13:45:02 UTC
svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4
Author: wrowe
Date: Mon Jun 27 13:45:02 2016
New Revision: 1750335
URL: http://svn.apache.org/viewvc?rev=1750335&view=rev
Log:
Ensure not-selected means 'no', once an APACHE_MODULE enable_foo is processed
Modified:
httpd/httpd/trunk/acinclude.m4
Modified: httpd/httpd/trunk/acinclude.m4
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/acinclude.m4?rev=1750335&r1=1750334&r2=1750335&view=diff
==============================================================================
--- httpd/httpd/trunk/acinclude.m4 (original)
+++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016
@@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[
"$force_$1" != "no" ; then
enable_$1=$module_default
_apmod_extra_msg=" ($module_selection)"
+ else
+ enable_$1=no
fi
if test "$enable_$1" != "no"; then
dnl If we plan to enable it, allow the module to run some autoconf magic
Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Mon, Jun 27, 2016 at 10:14 AM, William A Rowe Jr <wr...@rowe-clan.net>
wrote:
>
> On Jun 27, 2016 9:44 AM, "Ruediger Pluem" <rp...@apache.org> wrote:
> >
> >
> >
> > On 06/27/2016 04:35 PM, William A Rowe Jr wrote:
> > > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem <rpluem@apache.org
> <ma...@apache.org>> wrote:
> > >
> > > > --- httpd/httpd/trunk/acinclude.m4 (original)
> > > > +++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016
> > > > @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[
> > > > "$force_$1" != "no" ; then
> > > > enable_$1=$module_default
> > > > _apmod_extra_msg=" ($module_selection)"
> > > > + else
> > > > + enable_$1=no
> > >
> > > What if enable_$1 is set to shared by the the user of ./configure?
> Wouldn't that get overriden here?
> > >
> > > The valid cases of 'yes', 'shared', 'static', 'no', 'most' (??),
> 'maybe-all' (??), are all handled
> > > in the various if/elif cases above this change.
> >
> > I don't see the handling of 'shared' above, but maybe I missed it. Hence
> my question. I see static, yes, maybe-all,
> > most, but not shared.
>
> My eyes playing tricks on me, you are right.
>
> Running some various tests, hope to complete the fix this afternoon once I
> come up with any other obscure edge cases.
>
> > > The edge case of 'few' and 'reallyall' are not handled above, and we
> perhaps need to account
> > > for these? In any case, the old logic seems to always result in
> build-shared for unexpected
> > > values, no matter how silly they are (e.g. 'none').
> >
> > Agreed that it should be fixed.
>
Hopefully with the last commit it is... now exhaustively testing for the
rest of today
and looking for other strange cases.
> I still don't understand what --enable-modules=few (etc) are even supposed
> to mean.
>
... but am trying to unwind where that can come into play for enable_foo
(for mod_foo)
Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Jun 27, 2016 9:44 AM, "Ruediger Pluem" <rp...@apache.org> wrote:
>
>
>
> On 06/27/2016 04:35 PM, William A Rowe Jr wrote:
> > On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem <rpluem@apache.org
<ma...@apache.org>> wrote:
> >
> >
> > On 06/27/2016 03:45 PM, wrowe@apache.org <ma...@apache.org>
wrote:
> > > Author: wrowe
> > > Date: Mon Jun 27 13:45:02 2016
> > > New Revision: 1750335
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1750335&view=rev
> > > Log:
> > > Ensure not-selected means 'no', once an APACHE_MODULE enable_foo
is processed
> > >
> > > Modified:
> > > httpd/httpd/trunk/acinclude.m4
> > >
> > > Modified: httpd/httpd/trunk/acinclude.m4
> > > URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/acinclude.m4?rev=1750335&r1=1750334&r2=1750335&view=diff
> > >
==============================================================================
> > > --- httpd/httpd/trunk/acinclude.m4 (original)
> > > +++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016
> > > @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[
> > > "$force_$1" != "no" ; then
> > > enable_$1=$module_default
> > > _apmod_extra_msg=" ($module_selection)"
> > > + else
> > > + enable_$1=no
> >
> > What if enable_$1 is set to shared by the the user of ./configure?
Wouldn't that get overriden here?
> >
> >
> > The valid cases of 'yes', 'shared', 'static', 'no', 'most' (??),
'maybe-all' (??), are all handled
> > in the various if/elif cases above this change.
>
> I don't see the handling of 'shared' above, but maybe I missed it. Hence
my question. I see static, yes, maybe-all,
> most, but not shared.
My eyes playing tricks on me, you are right.
Running some various tests, hope to complete the fix this afternoon once I
come up with any other obscure edge cases.
> > The edge case of 'few' and 'reallyall' are not handled above, and we
perhaps need to account
> > for these? In any case, the old logic seems to always result in
build-shared for unexpected
> > values, no matter how silly they are (e.g. 'none').
> >
>
> Agreed that it should be fixed.
I still don't understand what --enable-modules=few (etc) are even supposed
to mean.
Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/27/2016 04:35 PM, William A Rowe Jr wrote:
> On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem <rpluem@apache.org <ma...@apache.org>> wrote:
>
>
> On 06/27/2016 03:45 PM, wrowe@apache.org <ma...@apache.org> wrote:
> > Author: wrowe
> > Date: Mon Jun 27 13:45:02 2016
> > New Revision: 1750335
> >
> > URL: http://svn.apache.org/viewvc?rev=1750335&view=rev
> > Log:
> > Ensure not-selected means 'no', once an APACHE_MODULE enable_foo is processed
> >
> > Modified:
> > httpd/httpd/trunk/acinclude.m4
> >
> > Modified: httpd/httpd/trunk/acinclude.m4
> > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/acinclude.m4?rev=1750335&r1=1750334&r2=1750335&view=diff
> > ==============================================================================
> > --- httpd/httpd/trunk/acinclude.m4 (original)
> > +++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016
> > @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[
> > "$force_$1" != "no" ; then
> > enable_$1=$module_default
> > _apmod_extra_msg=" ($module_selection)"
> > + else
> > + enable_$1=no
>
> What if enable_$1 is set to shared by the the user of ./configure? Wouldn't that get overriden here?
>
>
> The valid cases of 'yes', 'shared', 'static', 'no', 'most' (??), 'maybe-all' (??), are all handled
> in the various if/elif cases above this change.
I don't see the handling of 'shared' above, but maybe I missed it. Hence my question. I see static, yes, maybe-all,
most, but not shared.
>
> The edge case of 'few' and 'reallyall' are not handled above, and we perhaps need to account
> for these? In any case, the old logic seems to always result in build-shared for unexpected
> values, no matter how silly they are (e.g. 'none').
>
Agreed that it should be fixed.
Regards
R�diger
Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Mon, Jun 27, 2016 at 9:25 AM, Ruediger Pluem <rp...@apache.org> wrote:
>
> On 06/27/2016 03:45 PM, wrowe@apache.org wrote:
> > Author: wrowe
> > Date: Mon Jun 27 13:45:02 2016
> > New Revision: 1750335
> >
> > URL: http://svn.apache.org/viewvc?rev=1750335&view=rev
> > Log:
> > Ensure not-selected means 'no', once an APACHE_MODULE enable_foo is
> processed
> >
> > Modified:
> > httpd/httpd/trunk/acinclude.m4
> >
> > Modified: httpd/httpd/trunk/acinclude.m4
> > URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/acinclude.m4?rev=1750335&r1=1750334&r2=1750335&view=diff
> >
> ==============================================================================
> > --- httpd/httpd/trunk/acinclude.m4 (original)
> > +++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016
> > @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[
> > "$force_$1" != "no" ; then
> > enable_$1=$module_default
> > _apmod_extra_msg=" ($module_selection)"
> > + else
> > + enable_$1=no
>
> What if enable_$1 is set to shared by the the user of ./configure?
> Wouldn't that get overriden here?
>
The valid cases of 'yes', 'shared', 'static', 'no', 'most' (??),
'maybe-all' (??), are all handled
in the various if/elif cases above this change.
The edge case of 'few' and 'reallyall' are not handled above, and we
perhaps need to account
for these? In any case, the old logic seems to always result in
build-shared for unexpected
values, no matter how silly they are (e.g. 'none').
Re: svn commit: r1750335 - /httpd/httpd/trunk/acinclude.m4
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/27/2016 03:45 PM, wrowe@apache.org wrote:
> Author: wrowe
> Date: Mon Jun 27 13:45:02 2016
> New Revision: 1750335
>
> URL: http://svn.apache.org/viewvc?rev=1750335&view=rev
> Log:
> Ensure not-selected means 'no', once an APACHE_MODULE enable_foo is processed
>
> Modified:
> httpd/httpd/trunk/acinclude.m4
>
> Modified: httpd/httpd/trunk/acinclude.m4
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/acinclude.m4?rev=1750335&r1=1750334&r2=1750335&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/acinclude.m4 (original)
> +++ httpd/httpd/trunk/acinclude.m4 Mon Jun 27 13:45:02 2016
> @@ -375,6 +375,8 @@ AC_DEFUN([APACHE_MODULE],[
> "$force_$1" != "no" ; then
> enable_$1=$module_default
> _apmod_extra_msg=" ($module_selection)"
> + else
> + enable_$1=no
What if enable_$1 is set to shared by the the user of ./configure? Wouldn't that get overriden here?
Regards
R�diger