You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2022/06/06 19:23:00 UTC
[jira] [Commented] (SOLR-15740) Rewrite v2 schema APIs using annotation framework
[ https://issues.apache.org/jira/browse/SOLR-15740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550624#comment-17550624 ]
Jason Gerlowski commented on SOLR-15740:
----------------------------------------
bq. the branch I linked above punts on reading the request body entirely in the v2 API class (and thus doesn't have any Payload POJOs).
I ended up going with this approach and will link a PR shortly. I'm not thrilled about losing the command-level detail in the introspect output for these APIs. But I think there are v2 API tweaks we might consider in SOLR-15781 that might get us this back without needing to duplicate or double-consume the request body.
Related note: the v2 {{POST /config}} APIs share the same request-body-consumption issue as the schema APIs in this ticket; I plan on handling them with the same approach I detailed above for the schema APIs.
> Rewrite v2 schema APIs using annotation framework
> -------------------------------------------------
>
> Key: SOLR-15740
> URL: https://issues.apache.org/jira/browse/SOLR-15740
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Labels: V2
>
> Solr's v2 APIs can be implemented in 1 of 2 possible ways: an apispec (i.e. JSON file) based approach that was originally conceived when the v2 APIs were created, and an approach that relies on annotated POJO objects which has come into favor more recently as it results in less duplication and inches our APIs ones step towards a more strongly-typed future.
> The consensus has emerged across several JIRAs that the annotated-POJO approach is the one that should be used going forward, and that existing v2 APIs should be cut over as convenient.
> It's worth noting that this will cause the introspection output to lose the "description" text for these APIs and their parameters, as there's no support for this yet for annotation-based v2 APIs. See SOLR-15117 for more details.
> This ticket aims to tackle this conversion for Solr's schema APIs.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org