[jira] [Created] (IMPALA-11258) Test cases should verify there are no errors/warnings

["Quanlong Huang (Jira)" <ji...@apache.org>]

Quanlong Huang created IMPALA-11258:
---------------------------------------

             Summary: Test cases should verify there are no errors/warnings
                 Key: IMPALA-11258
                 URL: https://issues.apache.org/jira/browse/IMPALA-11258
             Project: IMPALA
          Issue Type: Test
            Reporter: Quanlong Huang
            Assignee: Quanlong Huang


During the review of [https://gerrit.cloudera.org/c/18413,] I see a test case that has warnings on memory leak still be able to pass. We currently just verify the expected error messages when there are ERRORS sections. We should verify that when no ERRORS section is provided, the test should have no warnings/errors.
{code:python}
  if 'ERRORS' in test_section:
    expected_errors = split_section_lines(remove_comments(test_section['ERRORS']))
    actual_errors = apply_error_match_filter(exec_result.log.split('\n'),
                                             replace_filenames)
    try:
      verify_errors(expected_errors, actual_errors)
    except AssertionError:
      if update_section:
        test_section['ERRORS'] = join_section_lines(actual_errors)
      else:
        raise{code}
[https://github.com/apache/impala/blob/1358700740dbeff799f6a6a95f95b1d9fe7281d2/tests/common/test_result_verifier.py#L373-L383]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org