You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/06/17 15:13:59 UTC

[GitHub] [logging-log4j2] hupfdule commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender

hupfdule commented on issue #224: [LOG4J2-2403] Allow zero padding the counter of a RollingFileAppender	
URL: https://github.com/apache/logging-log4j2/pull/224#issuecomment-502725794
 
 
   Thank you for taking the time to review this PR!
   
   I have prepared an [alternative PR](https://github.com/apache/logging-log4j2/pull/280) that does this change only in the IntegerPatternConverter using the format `%i{03}`.
   
   However this imposes an inconsistency with the justification that can already be specified and always uses spaces for padding as described in the [PatternLayout section of the Layout manual](https://logging.apache.org/log4j/2.x/manual/layouts.html#PatternLayout).
   
   Therefore I think the approach of this orginal PR is better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services