You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2015/06/04 22:55:09 UTC
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/789
[FLINK-2139] [streaming] Streaming outputformat tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink flink-2139
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit ea794885dce606059025c8618bc41607813091c3
Author: mbalassi <mb...@apache.org>
Date: 2015-06-04T09:04:46Z
[FLINK-2139] [streaming] Streaming outputformat tests
commit 710233a1675bf6b3081bf60ca958409da74cd04d
Author: mbalassi <mb...@apache.org>
Date: 2015-06-04T13:22:13Z
[streaming] Socket Client Sink propagates exceptions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/789#issuecomment-109216797
I think we need to name the "tests" ITCase. In my understanding the tests that bring up a test cluster and execute a program are ITCases since they take longer to run than simple tests. I might be wrong, though. Anyone else have an opinion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/789#issuecomment-109298498
Probably then, yes :smile: (for the rename)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/789#issuecomment-109196655
The socket test failed once in ten runs on travis, some messages were lost while writing and reading to the socket. do not think that we can avoid that completely. I can feed in less input data or remove the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/789#issuecomment-109218281
Both are good points.
As for the socket test I can do one of the following:
* Do not test it
* Test it with smaller data
* Mock the socket with some collection
I am not not really happy with any of these options to be honest, but maybe I am just missing something.
As for the ITCases, you are right, I have to admit that I was looking at the [AvroOutputFormatTest](https://github.com/apache/flink/blob/master/flink-staging/flink-avro/src/test/java/org/apache/flink/api/avro/AvroOutputFormatTest.java) and named my tests accordingly. So you would suggest renaming that too then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/789#issuecomment-109339446
Ok, I am renaming that and adding an ignore for the socket test and a JIRA to fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2139] [streaming] Streaming outputforma...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/789#issuecomment-109200889
I would be against adding a test for which we already know that it sometimes fails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---