You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2021/04/30 19:51:01 UTC
[GitHub] [incubator-hop] nadment opened a new pull request #785: HOP-2843 Remove an unsightly border on Windows
nadment opened a new pull request #785:
URL: https://github.com/apache/incubator-hop/pull/785
- Remove an unsightly border on Windows
- Rename some prefix 'job' to 'workflow'
Please check on other OS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] nadment commented on pull request #785: HOP-2843 Remove an unsightly border on Windows
Posted by GitBox <gi...@apache.org>.
nadment commented on pull request #785:
URL: https://github.com/apache/incubator-hop/pull/785#issuecomment-830418309
Changed are only in "Execution result" tab item
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters merged pull request #785: HOP-2843 Remove an unsightly border on Windows
Posted by GitBox <gi...@apache.org>.
mattcasters merged pull request #785:
URL: https://github.com/apache/incubator-hop/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #785: HOP-2843 Remove an unsightly border on Windows
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #785:
URL: https://github.com/apache/incubator-hop/pull/785#issuecomment-830420549
aha, I saw toolbar so thought it was the main toolbar... should have looked at the code better.
Before:
<img width="1335" alt="Screenshot 2021-04-30 at 23 48 23" src="https://user-images.githubusercontent.com/1140235/116757664-cb2e3800-aa0e-11eb-904b-cd536ceba596.png">
After:
<img width="1335" alt="Screenshot 2021-04-30 at 23 48 23" src="https://user-images.githubusercontent.com/1140235/116757776-0a5c8900-aa0f-11eb-893b-6b230717c7c9.png">
Looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #785: HOP-2843 Remove an unsightly border on Windows
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #785:
URL: https://github.com/apache/incubator-hop/pull/785#issuecomment-830410484
Os X
Before:
<img width="1738" alt="Screenshot 2021-04-30 at 23 27 55" src="https://user-images.githubusercontent.com/1140235/116756044-b9976100-aa0b-11eb-93e8-9dabd2dc64a7.png">
After:
<img width="1729" alt="Screenshot 2021-04-30 at 23 18 00" src="https://user-images.githubusercontent.com/1140235/116756059-c0be6f00-aa0b-11eb-9e93-f8e9b7d6b2d1.png">
No Big impact so I approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva edited a comment on pull request #785: HOP-2843 Remove an unsightly border on Windows
Posted by GitBox <gi...@apache.org>.
hansva edited a comment on pull request #785:
URL: https://github.com/apache/incubator-hop/pull/785#issuecomment-830420549
aha, I saw toolbar so thought it was the main toolbar... should have looked at the code better.
Before:
<img width="1335" alt="Screenshot 2021-04-30 at 23 48 23" src="https://user-images.githubusercontent.com/1140235/116757664-cb2e3800-aa0e-11eb-904b-cd536ceba596.png">
After:
<img width="913" alt="Screenshot 2021-04-30 at 23 51 48" src="https://user-images.githubusercontent.com/1140235/116757858-35df7380-aa0f-11eb-86ab-d989f16dea8c.png">
Looks great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org