You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/09/26 13:12:19 UTC

[GitHub] flink pull request #2549: [FLINK-4671] [table] Table API can not be built

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2549

    [FLINK-4671] [table] Table API can not be built

    This PR solves problems introduced by FLINK-3929 / 25a622f. Now the plugin is configured globally. All projects that depend on `flink-test-utils` should build again.
    
    @mxm what do you think?
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4671

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2549
    
----
commit 4f90737247a561e53069aabb7179f483bcee6507
Author: twalthr <tw...@apache.org>
Date:   2016-09-26T13:05:40Z

    [FLINK-4671] [table] Table API can not be built

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2549: [FLINK-4671] [table] Table API can not be built

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2549#discussion_r80472473
  
    --- Diff: pom.xml ---
    @@ -1081,6 +1081,15 @@ under the License.
     				</executions>
     			</plugin>
     
    +			<!-- Pull bundled transitive dependencies (e.g. Mini-KDC see DIRSHARED-134) -->
    --- End diff --
    
    Would change "e.g." to "i.e." because it is the only dependency which uses the bundle mechanism.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2549: [FLINK-4671] [table] Table API can not be built

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2549: [FLINK-4671] [table] Table API can not be built

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2549
  
    Looks good! +1 to merge when the tests have passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2549: [FLINK-4671] [table] Table API can not be built

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2549#discussion_r80472617
  
    --- Diff: pom.xml ---
    @@ -1081,6 +1081,15 @@ under the License.
     				</executions>
     			</plugin>
     
    +			<!-- Pull bundled transitive dependencies (e.g. Mini-KDC see DIRSHARED-134) -->
    --- End diff --
    
    Could we also keep the link for convenience? https://issues.apache.org/jira/browse/DIRSHARED-134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---