[jira] [Work logged] (HIVE-26108) Hive hardcodes hasMoreRows to false in thrift interface

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-26108?focusedWorklogId=778282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778282 ]

ASF GitHub Bot logged work on HIVE-26108:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jun/22 20:10
            Start Date: 03/Jun/22 20:10
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera opened a new pull request, #3343:
URL: https://github.com/apache/hive/pull/3343

   The exception was happening because the code that casts the Decimal64 to
   Decimal was not being added in filtered expressions.
   
   Once this code was added, it caused a regression in check_constraint.q. The
   reason for this was because we do not want to convert Decimal64 to Decimal
   if the expression explicitly handles decimal64 types. A method was added
   to these classes that will prevent the conversion in these cases.
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   The exception was happening because the code that casts the Decimal64 to
   Decimal was not being added in filtered expressions.
   
   Once this code was added, it caused a regression in check_constraint.q. The
   reason for this was because we do not want to convert Decimal64 to Decimal
   if the expression explicitly handles decimal64 types. A method was added
   to these classes that will prevent the conversion in these cases.
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Added a unit test which contained the bug.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 778282)
    Remaining Estimate: 0h
            Time Spent: 10m

> Hive hardcodes hasMoreRows to false in thrift interface
> -------------------------------------------------------
>
>                 Key: HIVE-26108
>                 URL: https://issues.apache.org/jira/browse/HIVE-26108
>             Project: Hive
>          Issue Type: Improvement
>          Components: CLI
>            Reporter: Steve Carlin
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Hive has the hasMoreRows field in the TFetchResults interface but always hardcodes this to false.
> This might be dangerous to set to the correct value just in case any client looks at this field so if we make this change, we should be careful.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)