You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2013/01/27 21:12:03 UTC

svn commit: r1439165 - /lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java

Author: rmuir
Date: Sun Jan 27 20:12:03 2013
New Revision: 1439165

URL: http://svn.apache.org/viewvc?rev=1439165&view=rev
Log:
stop the jenkins screaming: BytesRefArray.bytesUsed is NOT RIGHT

Modified:
    lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java

Modified: lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java?rev=1439165&r1=1439164&r2=1439165&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java (original)
+++ lucene/dev/branches/lucene4547/lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java Sun Jan 27 20:12:03 2013
@@ -44,9 +44,9 @@ class BinaryDocValuesWriter extends DocV
   public BinaryDocValuesWriter(FieldInfo fieldInfo, Counter iwBytesUsed) {
     this.fieldInfo = fieldInfo;
     this.bytesRefArray = new BytesRefArray(iwBytesUsed);
-    bytesUsed = bytesRefArray.bytesUsed();
+    bytesUsed = bytesRefArray.bytesUsed(); // nocommit: totally wrong!!!!
     this.iwBytesUsed = iwBytesUsed;
-    iwBytesUsed.addAndGet(bytesUsed);
+    //nocommit WRONG iwBytesUsed.addAndGet(bytesUsed);
   }
 
   public void addValue(int docID, BytesRef value) {
@@ -72,7 +72,7 @@ class BinaryDocValuesWriter extends DocV
 
   private void updateBytesUsed() {
     final long newBytesUsed = bytesRefArray.bytesUsed();
-    iwBytesUsed.addAndGet(newBytesUsed - bytesUsed);
+    // nocommit: WRONG iwBytesUsed.addAndGet(newBytesUsed - bytesUsed);
     bytesUsed = newBytesUsed;
   }