You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/22 16:06:22 UTC

[GitHub] ashb commented on a change in pull request #4571: [AIRFLOW-3419] S3_hook.select_key is broken on Python3

ashb commented on a change in pull request #4571: [AIRFLOW-3419] S3_hook.select_key is broken on Python3
URL: https://github.com/apache/airflow/pull/4571#discussion_r249847490
 
 

 ##########
 File path: airflow/hooks/S3_hook.py
 ##########
 @@ -272,7 +272,7 @@ def select_key(self, key, bucket_name=None,
             InputSerialization=input_serialization,
             OutputSerialization=output_serialization)
 
-        return ''.join(event['Records']['Payload']
+        return ''.join(event['Records']['Payload'].decode('utf-8')
 
 Review comment:
   This possibly needs to be a parameter (with a default value of `utf-8`) just in case not everyone's data is UTF-8

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services