[GitHub] [iceberg] jackye1995 commented on a diff in pull request #5304: AWS: handle_s3_glue_exception

[GitBox <gi...@apache.org>]

jackye1995 commented on code in PR #5304:
URL: https://github.com/apache/iceberg/pull/5304#discussion_r923966527


##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -144,6 +145,10 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) {
           "Cannot commit %s because Glue encountered a validation exception " +
               "while accessing requested resources",
           tableName());
+    } catch (S3Exception e) {
+      throw e;
+    } catch (software.amazon.awssdk.services.glue.model.GlueException e) {

Review Comment:
   nit: I don't think we need the full class path here, can import the class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org