You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/06/03 05:43:07 UTC
Review Request 34978: Configs: Different values in warnings tooltip
when config is in raw mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34978/
-----------------------------------------------------------
Review request for Ambari and Srimanth Gunturi.
Bugs: AMBARI-11638
https://issues.apache.org/jira/browse/AMBARI-11638
Repository: ambari
Description
-------
Add missing conversion. Fix wrong value update.
Diffs
-----
ambari-web/app/views/common/configs/widgets/config_widget_view.js a8b4b59
ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js d8bc02b
Diff: https://reviews.apache.org/r/34978/diff/
Testing
-------
Manually tested on live cluster.
Thanks,
Richard Zang
Re: Review Request 34978: Configs: Different values in warnings
tooltip when config is in raw mode.
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34978/#review86924
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On June 3, 2015, 3:43 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34978/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 3:43 a.m.)
>
>
> Review request for Ambari and Srimanth Gunturi.
>
>
> Bugs: AMBARI-11638
> https://issues.apache.org/jira/browse/AMBARI-11638
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add missing conversion. Fix wrong value update.
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/configs/widgets/config_widget_view.js a8b4b59
> ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js d8bc02b
>
> Diff: https://reviews.apache.org/r/34978/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 34978: Configs: Different values in warnings
tooltip when config is in raw mode.
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34978/#review86984
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On June 7, 2015, 9:50 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34978/
> -----------------------------------------------------------
>
> (Updated June 7, 2015, 9:50 p.m.)
>
>
> Review request for Ambari and Srimanth Gunturi.
>
>
> Bugs: AMBARI-11638
> https://issues.apache.org/jira/browse/AMBARI-11638
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add missing conversion. Fix wrong value update.
>
>
> Diffs
> -----
>
> ambari-web/app/views/common/configs/widgets/config_widget_view.js 86792be
> ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js 46a0657
> ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js 8a227ef
>
> Diff: https://reviews.apache.org/r/34978/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 34978: Configs: Different values in warnings
tooltip when config is in raw mode.
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34978/
-----------------------------------------------------------
(Updated June 7, 2015, 9:50 p.m.)
Review request for Ambari and Srimanth Gunturi.
Changes
-------
Fix UT.
Bugs: AMBARI-11638
https://issues.apache.org/jira/browse/AMBARI-11638
Repository: ambari
Description
-------
Add missing conversion. Fix wrong value update.
Diffs (updated)
-----
ambari-web/app/views/common/configs/widgets/config_widget_view.js 86792be
ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js 46a0657
ambari-web/test/views/common/configs/widgets/slider_config_widget_view_test.js 8a227ef
Diff: https://reviews.apache.org/r/34978/diff/
Testing
-------
Manually tested on live cluster.
Thanks,
Richard Zang