[jira] [Updated] (HBASE-5344) [89-fb] Scan unassigned region directory on master failover

["Phabricator (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-5344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-5344:
-------------------------------

    Attachment: D1605.1.patch

mbautin requested code review of "[jira] [HBASE-5344] [89-fb] Scan unassigned region directory on master failover".
Reviewers: Kannan, Karthik, Liyin, JIRA, stack

  In case the master dies after a regionserver writes region state as OPENED or CLOSED in ZK but before the update is received by master and written to meta, the new master that comes up has to pick up the region state from ZK and write it to meta. Otherwise we can get multiply-assigned regions.

  The current solution tries to reassign the root region if it is unassigned but does not implement a work-around if META regions are missing. Also, it currently heavily relies on "direct scanning" of regionservers (reading regionserver list from ZK and doing an RPC on each regionserver to get the list of online regions). We were already doing that in master failover, but I am making it parallel here.

TEST PLAN
  Unit tests, dev cluster, dark launch with killing regionservers and master

REVISION DETAIL
  https://reviews.facebook.net/D1605

AFFECTED FILES
  src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionEventData.java
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
  src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java
  src/main/java/org/apache/hadoop/hbase/master/DirectRegionServerScanner.java
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java
  src/main/java/org/apache/hadoop/hbase/master/ProcessRegionOpen.java
  src/main/java/org/apache/hadoop/hbase/master/RegionManager.java
  src/main/java/org/apache/hadoop/hbase/master/RootScanner.java
  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
  src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java
  src/main/java/org/apache/hadoop/hbase/master/handler/MasterOpenRegionHandler.java
  src/test/java/org/apache/hadoop/hbase/master/TestRegionStateOnMasterFailure.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/3429/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> [89-fb] Scan unassigned region directory on master failover
> -----------------------------------------------------------
>
>                 Key: HBASE-5344
>                 URL: https://issues.apache.org/jira/browse/HBASE-5344
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D1605.1.patch
>
>
> In case the master dies after a regionserver writes region state as OPENED or CLOSED in ZK but before the update is received by master and written to meta, the new master that comes up has to pick up the region state from ZK and write it to meta. Otherwise we can get multiply-assigned regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira