[GitHub] [arrow-rs] snmvaughan commented on a diff in pull request #3502: Feature/string comparison

[GitBox <gi...@apache.org>]

snmvaughan commented on code in PR #3502:
URL: https://github.com/apache/arrow-rs/pull/3502#discussion_r1066183472


##########
arrow-ord/src/comparison.rs:
##########
@@ -35,7 +35,7 @@ use arrow_select::take::take;
 
 /// Helper function to perform boolean lambda function on values from two array accessors, this
 /// version does not attempt to use SIMD.
-fn compare_op<T: ArrayAccessor, S: ArrayAccessor, F>(
+pub fn compare_op<T: ArrayAccessor, S: ArrayAccessor, F>(

Review Comment:
   I'll duplicate `compare_op` and `compare_op_scalar` and revert making those public.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org