You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Yuki Morishita (JIRA)" <ji...@apache.org> on 2016/06/07 16:54:21 UTC

[jira] [Commented] (CASSANDRA-11841) Add keep-alive to stream protocol

    [ https://issues.apache.org/jira/browse/CASSANDRA-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318862#comment-15318862 ] 

Yuki Morishita commented on CASSANDRA-11841:
--------------------------------------------

Thanks for the patch. Overall it seems good.
One thing to point out is I thing we should {{setRemoveOnCancelPolicy(true)}} on {{keepAliveExecutor}} otherwise the task may send keep alive to already closed connection.

Can you run tests again, since it seems they were not running properly?

> Add keep-alive to stream protocol
> ---------------------------------
>
>                 Key: CASSANDRA-11841
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11841
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)