You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/11/25 15:35:22 UTC
Review Request 28441: Unable to close Add Host Wizard at step 2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28441/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-8444
https://issues.apache.org/jira/browse/AMBARI-8444
Repository: ambari
Description
-------
STR
Proceed to step 2 of Add Host Wizard.
After hosts registration and checks, try to clode wizard.
Result
Wizard is not closed.
In the sidebar, step 1 ('Install Options') is set as active while step 2 is still displayed.
JS error:
Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
on
controllers/wizard/step2_controller.js:68
Workaround
Second attempt to close the wizard is successful.
Diffs
-----
ambari-web/app/controllers/main/host/add_controller.js 001175a
ambari-web/app/controllers/wizard.js e87984d
ambari-web/test/controllers/main/host/add_controller_test.js ea6a017
ambari-web/test/controllers/wizard_test.js 159ae03
Diff: https://reviews.apache.org/r/28441/diff/
Testing
-------
4895 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach
Re: Review Request 28441: Unable to close Add Host Wizard at step 2
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28441/#review62988
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Лис. 25, 2014, 2:35 після полудня, Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28441/
> -----------------------------------------------------------
>
> (Updated Лис. 25, 2014, 2:35 після полудня)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-8444
> https://issues.apache.org/jira/browse/AMBARI-8444
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
> Proceed to step 2 of Add Host Wizard.
> After hosts registration and checks, try to clode wizard.
> Result
> Wizard is not closed.
> In the sidebar, step 1 ('Install Options') is set as active while step 2 is still displayed.
> JS error:
> Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
> on
> controllers/wizard/step2_controller.js:68
> Workaround
> Second attempt to close the wizard is successful.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host/add_controller.js 001175a
> ambari-web/app/controllers/wizard.js e87984d
> ambari-web/test/controllers/main/host/add_controller_test.js ea6a017
> ambari-web/test/controllers/wizard_test.js 159ae03
>
> Diff: https://reviews.apache.org/r/28441/diff/
>
>
> Testing
> -------
>
> 4895 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>