Re: [PR] [fix][txn] Fix getting last message ID when there are ongoing transactions [pulsar]

["coderzc (via GitHub)" <gi...@apache.org>]

coderzc commented on PR #21466:
URL: https://github.com/apache/pulsar/pull/21466#issuecomment-1797146580

   > @coderzc
   > 
   > Could you please help review
   > 
   > > The MaxReadPosition should be the previous position of the first ongoing transaction position instead of EntryID -1.
   > > Compacted decide whether the topic's managedLedger is null by EntryID == -1
   > 
   > I'm not sure what does it actually means.
   
   
   
   > @coderzc
   > 
   > Could you please help review
   > 
   > > The MaxReadPosition should be the previous position of the first ongoing transaction position instead of EntryID -1.
   > > Compacted decide whether the topic's managedLedger is null by EntryID == -1
   > 
   > I'm not sure what does it actually means.
   
   I think this change is correct since the first entryID of ongoing maybe 0, and its previous entry can't be directly by entryID-1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org