You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Lubomir Rintel <lk...@v3.sk> on 2014/03/11 15:51:35 UTC

[PATCH 51648 apreq2] Remove redundant Apache2::Cookie::httpcookie documentation

---
Hi,

please review and merge this. It seems to be an easyfix, but the ticket [1] 
seemengly generated no useful attention.

[1] https://issues.apache.org/bugzilla/show_bug.cgi?id=51648

Thank you,
Lubo


 glue/perl/lib/Apache2/Cookie.pm | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/glue/perl/lib/Apache2/Cookie.pm b/glue/perl/lib/Apache2/Cookie.pm
index 715ab14..d6a5b31 100644
--- a/glue/perl/lib/Apache2/Cookie.pm
+++ b/glue/perl/lib/Apache2/Cookie.pm
@@ -450,20 +450,6 @@ Get or set the HttpOnly flag for the cookie:
 
 
 
-=head2 httponly
-
-    $cookie->httponly()
-    $cookie->httponly($set)
-
-Get or set the HttpOnly flag for the cookie:
-
-    $cookie->httponly(1);
-    $is_HttpOnly = $cookie->httponly;
-    $cookie->httponly(0);
-
-
-
-
 =head2 comment
 
     $cookie->comment()
-- 
1.8.3.1


Re: [PATCH 51648 apreq2] Remove redundant Apache2::Cookie::httpcookie documentation

Posted by Issac Goldstand <ma...@beamartyr.net>.

On 12/03/2014 14:42, Jeff Trawick wrote:
> On Tue, Mar 11, 2014 at 10:51 AM, Lubomir Rintel <lkundrak@v3.sk
> <ma...@v3.sk>> wrote:
> 
>     ---
>     Hi,
> 
>     please review and merge this. It seems to be an easyfix, but the
>     ticket [1]
>     seemengly generated no useful attention.
> 
> 
> Hi,
> 
> Where is the patched code maintained in ASF svn?  Is that part of the
> Perl project?
>  
> 
> 

in /httpd/apreq

I'll review if I have a chance


>     [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=51648
> 
>     Thank you,
>     Lubo
> 
> 
>      glue/perl/lib/Apache2/Cookie.pm | 14 --------------
>      1 file changed, 14 deletions(-)
> 
>     diff --git a/glue/perl/lib/Apache2/Cookie.pm
>     b/glue/perl/lib/Apache2/Cookie.pm
>     index 715ab14..d6a5b31 100644
>     --- a/glue/perl/lib/Apache2/Cookie.pm
>     +++ b/glue/perl/lib/Apache2/Cookie.pm
>     @@ -450,20 +450,6 @@ Get or set the HttpOnly flag for the cookie:
> 
> 
> 
>     -=head2 httponly
>     -
>     -    $cookie->httponly()
>     -    $cookie->httponly($set)
>     -
>     -Get or set the HttpOnly flag for the cookie:
>     -
>     -    $cookie->httponly(1);
>     -    $is_HttpOnly = $cookie->httponly;
>     -    $cookie->httponly(0);
>     -
>     -
>     -
>     -
>      =head2 comment
> 
>          $cookie->comment()
>     --
>     1.8.3.1
> 
> 
> 
> 
> -- 
> Born in Roswell... married an alien...
> http://emptyhammock.com/
> http://edjective.org/
> 


Re: [PATCH 51648 apreq2] Remove redundant Apache2::Cookie::httpcookie documentation

Posted by Jeff Trawick <tr...@gmail.com>.
On Wed, Mar 12, 2014 at 10:22 AM, Lubomir Rintel <lk...@v3.sk> wrote:

> Hello,
>
> On Wed, 2014-03-12 at 08:42 -0400, Jeff Trawick wrote:
> > On Tue, Mar 11, 2014 at 10:51 AM, Lubomir Rintel <lk...@v3.sk> wrote:
> >
> > > ---
> > > Hi,
> > >
> > > please review and merge this. It seems to be an easyfix, but the
> ticket [1]
> > > seemengly generated no useful attention.
> > >
> >
> > Hi,
> >
> > Where is the patched code maintained in ASF svn?  Is that part of the
> Perl
> > project?
>
> According to the project web site [1] it's
> <http://svn.apache.org/repos/asf/httpd/apreq/trunk/>
>

Thanks :)  I was looking in the wrong tree.


>
> [1] https://httpd.apache.org/apreq/
>
> Thanks,
> Lubo
>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/

Re: [PATCH 51648 apreq2] Remove redundant Apache2::Cookie::httpcookie documentation

Posted by Lubomir Rintel <lk...@v3.sk>.
Hello,

On Wed, 2014-03-12 at 08:42 -0400, Jeff Trawick wrote:
> On Tue, Mar 11, 2014 at 10:51 AM, Lubomir Rintel <lk...@v3.sk> wrote:
> 
> > ---
> > Hi,
> >
> > please review and merge this. It seems to be an easyfix, but the ticket [1]
> > seemengly generated no useful attention.
> >
> 
> Hi,
> 
> Where is the patched code maintained in ASF svn?  Is that part of the Perl
> project?

According to the project web site [1] it's
<http://svn.apache.org/repos/asf/httpd/apreq/trunk/>

[1] https://httpd.apache.org/apreq/

Thanks,
Lubo


Re: [PATCH 51648 apreq2] Remove redundant Apache2::Cookie::httpcookie documentation

Posted by Jeff Trawick <tr...@gmail.com>.
On Tue, Mar 11, 2014 at 10:51 AM, Lubomir Rintel <lk...@v3.sk> wrote:

> ---
> Hi,
>
> please review and merge this. It seems to be an easyfix, but the ticket [1]
> seemengly generated no useful attention.
>

Hi,

Where is the patched code maintained in ASF svn?  Is that part of the Perl
project?


>
> [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=51648
>
> Thank you,
> Lubo
>
>
>  glue/perl/lib/Apache2/Cookie.pm | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/glue/perl/lib/Apache2/Cookie.pm
> b/glue/perl/lib/Apache2/Cookie.pm
> index 715ab14..d6a5b31 100644
> --- a/glue/perl/lib/Apache2/Cookie.pm
> +++ b/glue/perl/lib/Apache2/Cookie.pm
> @@ -450,20 +450,6 @@ Get or set the HttpOnly flag for the cookie:
>
>
>
> -=head2 httponly
> -
> -    $cookie->httponly()
> -    $cookie->httponly($set)
> -
> -Get or set the HttpOnly flag for the cookie:
> -
> -    $cookie->httponly(1);
> -    $is_HttpOnly = $cookie->httponly;
> -    $cookie->httponly(0);
> -
> -
> -
> -
>  =head2 comment
>
>      $cookie->comment()
> --
> 1.8.3.1
>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/