You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/29 14:42:09 UTC
[GitHub] [flink] zentol opened a new pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
zentol opened a new pull request #17608:
URL: https://github.com/apache/flink/pull/17608
Based on #17606.
We now use the Flink ClassLoader to deserialize the message payload. This should be safe because this serialization only occurs for results from the Flink layer, not the Akka RPC layer (where the Akka classloader would be required for deserialization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r742040650
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
of course, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6d48a2a8d555b42b1720db653674b73eb1b8ba0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662)
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r741954872
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
I'd suggest to use the `flinkClassLoader` instead of the context class loader. I think this is a bit more robust and explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17608:
URL: https://github.com/apache/flink/pull/17608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6d48a2a8d555b42b1720db653674b73eb1b8ba0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49487256bfb6ae8d304a42330454651924d001fb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49487256bfb6ae8d304a42330454651924d001fb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r742040650
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
of course, good catch
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
of course, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803417
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 49487256bfb6ae8d304a42330454651924d001fb (Fri Oct 29 14:46:10 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49487256bfb6ae8d304a42330454651924d001fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
}, {
"hash" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885",
"triggerID" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"triggerType" : "PUSH"
}, {
"hash" : "df7976eb97e12a6264aed898e16a71d09e6178ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25928",
"triggerID" : "df7976eb97e12a6264aed898e16a71d09e6178ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2a3becfcacbe9ae70744812ea0d1711c3dcd47 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885)
* df7976eb97e12a6264aed898e16a71d09e6178ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25928)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49487256bfb6ae8d304a42330454651924d001fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648)
* e6d48a2a8d555b42b1720db653674b73eb1b8ba0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r741954872
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
I'd suggest to use the `flinkClassLoader` instead of the context class loader. I think this is a bit more robust and explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
}, {
"hash" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885",
"triggerID" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737)
* 1b2a3becfcacbe9ae70744812ea0d1711c3dcd47 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e6d48a2a8d555b42b1720db653674b73eb1b8ba0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662)
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
}, {
"hash" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885",
"triggerID" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2a3becfcacbe9ae70744812ea0d1711c3dcd47 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49487256bfb6ae8d304a42330454651924d001fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648)
* e6d48a2a8d555b42b1720db653674b73eb1b8ba0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r742040650
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
of course, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
}, {
"hash" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5de7ecb7f3acc909a9f46372d4b07e9865103ce0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737)
* 1b2a3becfcacbe9ae70744812ea0d1711c3dcd47 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17608:
URL: https://github.com/apache/flink/pull/17608#issuecomment-954803172
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "49487256bfb6ae8d304a42330454651924d001fb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25648",
"triggerID" : "49487256bfb6ae8d304a42330454651924d001fb",
"triggerType" : "PUSH"
}, {
"hash" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25662",
"triggerID" : "e6d48a2a8d555b42b1720db653674b73eb1b8ba0",
"triggerType" : "PUSH"
}, {
"hash" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25737",
"triggerID" : "5de7ecb7f3acc909a9f46372d4b07e9865103ce0",
"triggerType" : "PUSH"
}, {
"hash" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885",
"triggerID" : "1b2a3becfcacbe9ae70744812ea0d1711c3dcd47",
"triggerType" : "PUSH"
}, {
"hash" : "df7976eb97e12a6264aed898e16a71d09e6178ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "df7976eb97e12a6264aed898e16a71d09e6178ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b2a3becfcacbe9ae70744812ea0d1711c3dcd47 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25885)
* df7976eb97e12a6264aed898e16a71d09e6178ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #17608: [FLINK-24550][rpc] Use ContextClassLoader for message deserialization
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #17608:
URL: https://github.com/apache/flink/pull/17608#discussion_r741954872
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
I'd suggest to use the `flinkClassLoader` instead of the context class loader. I think this is a bit more robust and explicit.
##########
File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
##########
@@ -413,7 +413,7 @@ static Object deserializeValueIfNeeded(Object o, Method method) {
if (o instanceof AkkaRpcSerializedValue) {
try {
return ((AkkaRpcSerializedValue) o)
- .deserializeValue(AkkaInvocationHandler.class.getClassLoader());
+ .deserializeValue(Thread.currentThread().getContextClassLoader());
Review comment:
I'd suggest to use the `flinkClassLoader` instead of the context class loader. I think this is a bit more robust and explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org