You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by jd...@apache.org on 2025/07/29 13:12:37 UTC

(incubator-grails-gradle-publish) 03/04: chore: update comment to better explain why this code is needed

This is an automated email from the ASF dual-hosted git repository.

jdaugherty pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/incubator-grails-gradle-publish.git

commit 775326fd5a337bcfa4dc23a150ec086c48725f85
Author: James Daugherty <jd...@jdresources.net>
AuthorDate: Tue Jul 29 09:10:38 2025 -0400

    chore: update comment to better explain why this code is needed
---
 .../apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy  | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/plugin/src/main/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy b/plugin/src/main/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy
index e0728d7..d6515ac 100644
--- a/plugin/src/main/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy
+++ b/plugin/src/main/groovy/org/apache/grails/gradle/publish/GrailsPublishGradlePlugin.groovy
@@ -376,7 +376,12 @@ Note: if project properties are used, the properties must be defined prior to ap
                                 gpe.pomCustomization.call()
                             }
 
-                            // fix dependencies without a version
+                            // fix dependencies without a version, this can occur when the spring dependency management plugin is used
+                            // disabling that plugin will cause gradle to fail on any unresolved, or by disabling the check with:
+                            // https://github.com/gradle/gradle/issues/23030
+                            //tasks.withType(GenerateModuleMetadata).configureEach {
+                            //    suppressedValidationErrors.add('dependencies-without-versions')
+                            //}
                             if (gpe.transitiveDependencies.get()) {
                                 def mavenPomNamespace = 'http://maven.apache.org/POM/4.0.0'
                                 def dependenciesQName = new QName(mavenPomNamespace, 'dependencies')