[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #10451: Moving Zk updates for reload, force_commit to their own Znodes which …

["swaminathanmanish (via GitHub)" <gi...@apache.org>]

swaminathanmanish commented on code in PR #10451:
URL: https://github.com/apache/pinot/pull/10451#discussion_r1156375780


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -635,8 +635,8 @@ public ServerReloadControllerJobStatusResponse getReloadJobStatus(
     Map<String, List<String>> serverToSegments;
 
     String singleSegmentName = null;
-    if (controllerJobZKMetadata.get(CommonConstants.ControllerJob.JOB_TYPE)
-        .equals(ControllerJobType.RELOAD_SEGMENT.toString())) {
+    if (controllerJobZKMetadata.get(CommonConstants.ControllerJob.SEGMENT_RELOAD_JOB_SEGMENT_NAME)
+       != null) {

Review Comment:
   Yes, reload and reload_all are related, so combined into a single jobType. If the reload is tied to specific segment, then its a simple reload , otherwise reload_all. So, there's probably no real need to have 2 separate types. Also since we are creating Zk nodes per type, we wanted to restrict to 3 jobTypes. 
   cc @saurabhd336 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org