You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/03/11 00:18:22 UTC
Review Request 18988: Improved gate.hpp documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18988/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
A trivial patch. Added some documentation as I was reading the class hopefully to help libprocess newbies.
Diffs
-----
3rdparty/libprocess/src/gate.hpp 954f6208d4e14b95742e2dc67c564e4ed2e0a96e
Diff: https://reviews.apache.org/r/18988/diff/
Testing
-------
N/A
Thanks,
Jiang Yan Xu
Re: Review Request 18988: Improved gate.hpp documentation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18988/#review36734
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18988]
All tests passed.
- Mesos ReviewBot
On March 10, 2014, 11:18 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18988/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 11:18 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> A trivial patch. Added some documentation as I was reading the class hopefully to help libprocess newbies.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/gate.hpp 954f6208d4e14b95742e2dc67c564e4ed2e0a96e
>
> Diff: https://reviews.apache.org/r/18988/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 18988: Improved gate.hpp documentation.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18988/#review46238
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 11, 2014, 1:07 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18988/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 1:07 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> A trivial patch. Added some documentation as I was reading the class hopefully to help libprocess newbies.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/gate.hpp 954f6208d4e14b95742e2dc67c564e4ed2e0a96e
>
> Diff: https://reviews.apache.org/r/18988/diff/
>
>
> Testing
> -------
>
> N/A
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 18988: Improved gate.hpp documentation.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18988/
-----------------------------------------------------------
(Updated March 11, 2014, 1:07 a.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
assigning to @benjaminhindman -- Vinod
Repository: mesos-git
Description
-------
A trivial patch. Added some documentation as I was reading the class hopefully to help libprocess newbies.
Diffs
-----
3rdparty/libprocess/src/gate.hpp 954f6208d4e14b95742e2dc67c564e4ed2e0a96e
Diff: https://reviews.apache.org/r/18988/diff/
Testing
-------
N/A
Thanks,
Jiang Yan Xu