You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jonathan Keane (Jira)" <ji...@apache.org> on 2021/04/01 20:20:00 UTC
[jira] [Commented] (ARROW-12182) new helpers and suggests for
testing
[ https://issues.apache.org/jira/browse/ARROW-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313425#comment-17313425 ]
Jonathan Keane commented on ARROW-12182:
----------------------------------------
Do you have examples of the arrow tests you would want to construct that would require the {{expect_dplyr-*()}} helpers you're proposing? A concrete example + an implementation of those would be helpful in evaluating if those are helpful.
> new helpers and suggests for testing
> ------------------------------------
>
> Key: ARROW-12182
> URL: https://issues.apache.org/jira/browse/ARROW-12182
> Project: Apache Arrow
> Issue Type: Bug
> Components: R
> Affects Versions: 3.0.0
> Reporter: Mauricio 'Pachá' Vargas Sepúlveda
> Assignee: Mauricio 'Pachá' Vargas Sepúlveda
> Priority: Blocker
>
> _Related to https://issues.apache.org/jira/browse/ARROW-11705_
> While working on the related tickets I've found the next blockers:
> 1. Does it make sense to create expect_dplyr_named()? (i.e. to mimic https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L56-L59)
> 2. Does it make sense to create expect_dplyr_identical() (i.e. to mimic https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L61-L69 and https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L83-L91)
> 3. Should we need to add glue to Suggests? (i.e. replicate https://github.com/tidyverse/dplyr/blob/master/tests/testthat/test-mutate.r#L95-L100)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)