[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #9733: [Feature][Deploy] Add missing default values in dolphinscheduler_env.sh

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #9733:
URL: https://github.com/apache/dolphinscheduler/pull/9733#discussion_r858767146


##########
docs/docs/en/guide/installation/pseudo-cluster.md:
##########
@@ -168,13 +171,20 @@ mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'%';
 mysql> CREATE USER '{user}'@'localhost' IDENTIFIED BY '{password}';
 mysql> GRANT ALL PRIVILEGES ON dolphinscheduler.* TO '{user}'@'localhost';
 mysql> FLUSH PRIVILEGES;
-```
+``` 
 
-Change the username and password in `tools/conf/application.yaml` to {user} and {password} you set in the previous step. 
+Then, modify `./bin/env/dolphinscheduler_env.sh` to use mysql, change {user} and {password} to what you set in the previous step.
 
-Then, modify `tools/bin/dolphinscheduler_env.sh`, set mysql as default database `export DATABASE=${DATABASE:-mysql}`.  
+```shell
+export DATABASE=${DATABASE:-mysql}
+export SPRING_PROFILES_ACTIVE=${DATABASE}
+export SPRING_DATASOURCE_DRIVER_CLASS_NAME=com.mysql.jdbc.Driver

Review Comment:
   The mysql package version used by ds is ```8.0.16```. Therefore we should use ```com.mysql.cj.jdbc.Driver``` instead of ```com.mysql.jdbc.Driver```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org