You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/06/23 03:50:36 UTC
Review Request 35760: Removing GcExecutorLauncher code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334
Repository: aurora
Description
-------
Jave side of changes for removing gc executor support.
TaskLauncher refactoring will be addressed in a separate diff.
Diffs
-----
config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
Diff: https://reviews.apache.org/r/35760/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 23, 2015, 2:19 a.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java, line 69
> > <https://reviews.apache.org/r/35760/diff/1/?file=990090#file990090line69>
> >
> > We can remove this test now that the gc executor is gone.
Seems like a valid test to have as the underlying functionality is still in use.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review88901
-----------------------------------------------------------
On June 23, 2015, 1:50 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:50 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review88901
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java (line 69)
<https://reviews.apache.org/r/35760/#comment141516>
We can remove this test now that the gc executor is gone.
- Zameer Manji
On June 22, 2015, 6:50 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 6:50 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review88899
-----------------------------------------------------------
Master (2df2db9) is red with this patch.
./build-support/jenkins/build.sh
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
Exception: java.lang.AssertionError thrown from the UncaughtExceptionHandler in thread "Test-0"
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.895960482537609 exceeds minimum coverage of 0.89.
Branch coverage is 0.8241708314402544, but must be greater than 0.835
:analyzeReport FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/Protobufs
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 5 mins 10.922 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 23, 2015, 1:50 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:50 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review88983
-----------------------------------------------------------
Ship it!
Master (2df2db9) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:24 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On June 23, 2015, 5:49 p.m., Bill Farner wrote:
> > docs/storage-config.md, line 103
> > <https://reviews.apache.org/r/35760/diff/2/?file=990568#file990568line103>
> >
> > Consider a significantly higher number as the advice to make it clear, e.g. 365days.
Done.
> On June 23, 2015, 5:49 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 108
> > <https://reviews.apache.org/r/35760/diff/2/?file=990572#file990572line108>
> >
> > while you're here, remove this newline
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89007
-----------------------------------------------------------
On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:24 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89007
-----------------------------------------------------------
Ship it!
LGTM so long as end-to-end tests come up green.
docs/storage-config.md (line 103)
<https://reviews.apache.org/r/35760/#comment141602>
Consider a significantly higher number as the advice to make it clear, e.g. 365days.
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java (line 104)
<https://reviews.apache.org/r/35760/#comment141603>
while you're here, remove this newline
- Bill Farner
On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 2:24 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/#review89016
-----------------------------------------------------------
Ship it!
Master (2df2db9) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 23, 2015, 6 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35760/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 6 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1334
> https://issues.apache.org/jira/browse/AURORA-1334
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Jave side of changes for removing gc executor support.
>
> TaskLauncher refactoring will be addressed in a separate diff.
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
> debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
> debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
> debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
> docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
> examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
> examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
> src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
> src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
> src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
>
> Diff: https://reviews.apache.org/r/35760/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/
-----------------------------------------------------------
(Updated June 23, 2015, 6 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Bill's comments.
Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334
Repository: aurora
Description
-------
Jave side of changes for removing gc executor support.
TaskLauncher refactoring will be addressed in a separate diff.
Diffs (updated)
-----
config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
Diff: https://reviews.apache.org/r/35760/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 35760: Removing GcExecutorLauncher code.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35760/
-----------------------------------------------------------
(Updated June 23, 2015, 2:24 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Adding missing Protobufs coverage and refactoring CommandUtilTest.
Bugs: AURORA-1334
https://issues.apache.org/jira/browse/AURORA-1334
Repository: aurora
Description
-------
Jave side of changes for removing gc executor support.
TaskLauncher refactoring will be addressed in a separate diff.
Diffs (updated)
-----
config/legacy_untested_classes.txt d2f3ca50d32abf945f58b5fb67cd27c0b127822d
debian/aurora-scheduler.default 47fea5b4e6dadab9704c6ea5141268a91803fdc2
debian/aurora-scheduler.init 2ed0159d36d4be08f2c355dc1c21f36192a819f4
debian/aurora-scheduler.upstart ed7fe0917147d9c36a0828cc701da902142f72ba
docs/storage-config.md 971bc1673f8be800f0d081a44018fc17a5ed025a
examples/scheduler/scheduler-local.sh 6253d505f9851aea613bc95c15c313b03b57af11
examples/vagrant/upstart/aurora-scheduler-kerberos.conf 414539b1917b5d33c577f1539575934c7f7c8167
examples/vagrant/upstart/aurora-scheduler.conf f4b867cbbcdbcc792518c2f90807834e47dce253
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 6edec22aba135136c4ce4066b9535f23de077db7
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8bcac6c4f93eaca7250d43ab81a72102b91bf836
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java f2ef70ddc5a859811f0e6c2ade62e115639c1654
src/test/java/org/apache/aurora/ProtobufsTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java d2ec944ca12456c23eb54c9be8b1e6756f35e7f1
src/test/java/org/apache/aurora/scheduler/base/CommandUtilTest.java ec43a44d9cbd0f303e4833953cdb65664d5ed569
Diff: https://reviews.apache.org/r/35760/diff/
Testing
-------
Thanks,
Maxim Khutornenko