[GitHub] [iceberg] marton-bod commented on a change in pull request #1631: Use TestHiveShell to run StorageHandler tests. Use Parameterized runner.

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #1631:
URL: https://github.com/apache/iceberg/pull/1631#discussion_r507914731



##########
File path: build.gradle
##########
@@ -463,12 +463,10 @@ project(':iceberg-mr') {
     testCompile("org.apache.calcite:calcite-core")
     testCompile("com.esotericsoftware:kryo-shaded:4.0.2")
     testCompile("com.fasterxml.jackson.core:jackson-annotations:2.6.5")
-    testCompile("com.klarna:hiverunner:5.2.1") {
-      exclude group: 'javax.jms', module: 'jms'
+    testCompile("org.apache.hive:hive-service") {
       exclude group: 'org.apache.hive', module: 'hive-exec'
-      exclude group: 'org.codehaus.jettison', module: 'jettison'
-      exclude group: 'org.apache.calcite.avatica'
     }
+    testCompile("org.apache.tez:tez-dag:0.8.4")

Review comment:
       You're right, thanks. It's not required for Hive2, indeed. I've removed the dependency.
   On the other hand, it is needed for Hive3, where `HiveServer2.start()` initializes a `TezSessionPoolManager`, which depends on some Tez code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org