You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/10/27 21:18:18 UTC
Review Request 39696: Express Upgrade Packs For Hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39696/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-13588
https://issues.apache.org/jira/browse/AMBARI-13588
Repository: ambari
Description
-------
Ensure that EU Hive upgrade packs work correctly for the following scenarios:
- HDP 2.1 to 2.3 (configuration changes needed)
- HDP 2.2. to 2.2 (no config changes)
- HDP 2.2 to 2.3 (configuration changes needed)
- HDP 2.3 to 2.3 (no config changes)
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 0cacb07
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 8bdccdc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d7542e9
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 412edc7
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 0f6b8f1
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b5add07
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c091bb7
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml fe8e1fe
Diff: https://reviews.apache.org/r/39696/diff/
Testing
-------
Hive Upgrades from:
2.1 to 2.3
2.2 to 2.3
2.3 to 2.3
Thanks,
Jonathan Hurley
Re: Review Request 39696: Express Upgrade Packs For Hive
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Oct. 27, 2015, 4:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py, line 51
> > <https://reviews.apache.org/r/39696/diff/1/?file=1109661#file1109661line51>
> >
> > The start() and stop() commands needs to accept upgrade_type=None
> >
> > and pass it to hive_service(...)
Interesting; I didn't see those changes in Script the first time. I'll make the changes - things worked b/c of the legacy code in script.py
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39696/#review104203
-----------------------------------------------------------
On Oct. 27, 2015, 4:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39696/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 4:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13588
> https://issues.apache.org/jira/browse/AMBARI-13588
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ensure that EU Hive upgrade packs work correctly for the following scenarios:
>
> - HDP 2.1 to 2.3 (configuration changes needed)
> - HDP 2.2. to 2.2 (no config changes)
> - HDP 2.2 to 2.3 (configuration changes needed)
> - HDP 2.3 to 2.3 (no config changes)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 0cacb07
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 8bdccdc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d7542e9
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 412edc7
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 0f6b8f1
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b5add07
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c091bb7
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml fe8e1fe
>
> Diff: https://reviews.apache.org/r/39696/diff/
>
>
> Testing
> -------
>
> Hive Upgrades from:
> 2.1 to 2.3
> 2.2 to 2.3
> 2.3 to 2.3
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 39696: Express Upgrade Packs For Hive
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39696/#review104203
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py (line 51)
<https://reviews.apache.org/r/39696/#comment162493>
The start() and stop() commands needs to accept upgrade_type=None
and pass it to hive_service(...)
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py (line 80)
<https://reviews.apache.org/r/39696/#comment162494>
The start() and stop() commands needs to accept upgrade_type=None
and pass it to hive_service(...)
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py (line 90)
<https://reviews.apache.org/r/39696/#comment162495>
Instead, this will be, if upgrade_type == "rolling":
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py (line 38)
<https://reviews.apache.org/r/39696/#comment162496>
The start() and stop() commands needs to accept upgrade_type=None
and pass it to webhcat_service(...)
- Alejandro Fernandez
On Oct. 27, 2015, 8:18 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39696/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 8:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13588
> https://issues.apache.org/jira/browse/AMBARI-13588
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ensure that EU Hive upgrade packs work correctly for the following scenarios:
>
> - HDP 2.1 to 2.3 (configuration changes needed)
> - HDP 2.2. to 2.2 (no config changes)
> - HDP 2.2 to 2.3 (configuration changes needed)
> - HDP 2.3 to 2.3 (no config changes)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 0cacb07
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 8bdccdc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d7542e9
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 412edc7
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 0f6b8f1
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b5add07
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c091bb7
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml fe8e1fe
>
> Diff: https://reviews.apache.org/r/39696/diff/
>
>
> Testing
> -------
>
> Hive Upgrades from:
> 2.1 to 2.3
> 2.2 to 2.3
> 2.3 to 2.3
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 39696: Express Upgrade Packs For Hive
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39696/#review104216
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 27, 2015, 9:28 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39696/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 9:28 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
>
>
> Bugs: AMBARI-13588
> https://issues.apache.org/jira/browse/AMBARI-13588
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ensure that EU Hive upgrade packs work correctly for the following scenarios:
>
> - HDP 2.1 to 2.3 (configuration changes needed)
> - HDP 2.2. to 2.2 (no config changes)
> - HDP 2.2 to 2.3 (configuration changes needed)
> - HDP 2.3 to 2.3 (no config changes)
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/constants.py 99ff679
> ambari-common/src/main/python/resource_management/libraries/script/script.py 79bc535
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 0cacb07
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 8bdccdc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d7542e9
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py ccb4f7d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 5fdaa70
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 412edc7
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 46ad109
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 0f6b8f1
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b5add07
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c091bb7
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml fe8e1fe
>
> Diff: https://reviews.apache.org/r/39696/diff/
>
>
> Testing
> -------
>
> Hive Upgrades from:
> 2.1 to 2.3
> 2.2 to 2.3
> 2.3 to 2.3
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 39696: Express Upgrade Packs For Hive
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39696/
-----------------------------------------------------------
(Updated Oct. 27, 2015, 5:28 p.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
Bugs: AMBARI-13588
https://issues.apache.org/jira/browse/AMBARI-13588
Repository: ambari
Description
-------
Ensure that EU Hive upgrade packs work correctly for the following scenarios:
- HDP 2.1 to 2.3 (configuration changes needed)
- HDP 2.2. to 2.2 (no config changes)
- HDP 2.2 to 2.3 (configuration changes needed)
- HDP 2.3 to 2.3 (no config changes)
Diffs (updated)
-----
ambari-common/src/main/python/ambari_commons/constants.py 99ff679
ambari-common/src/main/python/resource_management/libraries/script/script.py 79bc535
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py 0cacb07
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 8bdccdc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py d7542e9
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py ccb4f7d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py 5fdaa70
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py 412edc7
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 46ad109
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 0f6b8f1
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml b5add07
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml c091bb7
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml fe8e1fe
Diff: https://reviews.apache.org/r/39696/diff/
Testing
-------
Hive Upgrades from:
2.1 to 2.3
2.2 to 2.3
2.3 to 2.3
Thanks,
Jonathan Hurley