[GitHub] [incubator-teaclave-sgx-sdk] dingelish edited a comment on issue #251: libc::free core dump due to invalid address

[GitBox <gi...@apache.org>]

dingelish edited a comment on issue #251:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/issues/251#issuecomment-647832391


   (1) libc::free in TEE is designed to fail. it's because p points to untrusted memory and enclave's memory allocator cannot do anything on external heap.
   
   (2) could you please paste your EDl definition of ocall_free as well as its implementation? since your passing a pointer, EDL requires you to demonstrate the direction and conduct memcpy according to the definition. in this case, the pointer is a [in] argument of ocall_free, but no need of memory copy. so the most simple solution is to pass the argument in immediate value like uint64_t, or mark it as `usercheck` and avoid from "pointer semantics" caused memcpy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org