You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Steven Tippetts (JIRA)" <ji...@apache.org> on 2012/12/03 19:19:58 UTC
[jira] [Created] (CXF-4670) [OAuth2] Add tokenLife property to
org.apache.cxf.rs.security.oauth2.common.Client
Steven Tippetts created CXF-4670:
------------------------------------
Summary: [OAuth2] Add tokenLife property to org.apache.cxf.rs.security.oauth2.common.Client
Key: CXF-4670
URL: https://issues.apache.org/jira/browse/CXF-4670
Project: CXF
Issue Type: Improvement
Components: JAX-RS Security
Affects Versions: 2.7.0
Reporter: Steven Tippetts
Priority: Minor
I'm currently extending Client to get this property, so it's no big deal for me; however, I'm thinking this may have wider appeal and be a good addition to the library.
My clients have different token lives so tokenLife helps me keep track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4670) [OAuth2] Add tokenLife property to
org.apache.cxf.rs.security.oauth2.common.Client
Posted by "Steven Tippetts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509791#comment-13509791 ]
Steven Tippetts commented on CXF-4670:
--------------------------------------
Yes, that works for me. Thanks.
> [OAuth2] Add tokenLife property to org.apache.cxf.rs.security.oauth2.common.Client
> ----------------------------------------------------------------------------------
>
> Key: CXF-4670
> URL: https://issues.apache.org/jira/browse/CXF-4670
> Project: CXF
> Issue Type: Improvement
> Components: JAX-RS Security
> Affects Versions: 2.7.0
> Reporter: Steven Tippetts
> Priority: Minor
>
> I'm currently extending Client to get this property, so it's no big deal for me; however, I'm thinking this may have wider appeal and be a good addition to the library.
> My clients have different token lives so tokenLife helps me keep track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4670) [OAuth2] Add tokenLife property to
org.apache.cxf.rs.security.oauth2.common.Client
Posted by "Steven Tippetts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509076#comment-13509076 ]
Steven Tippetts commented on CXF-4670:
--------------------------------------
Not really. In my ImplicitDataProvider object, in the getClient is where I do my database calls to get client information, including the token life for this client. I then use the token life number in both createAccessToken and getAccessToken when I create BearerAccessTokens (which is an AccessToken and has its expiresIn property set by the value I pass in). If I don't save the token life value in Client during getClient then I'll have to hit the database again in both createAccessToken and getAccessToken.
> [OAuth2] Add tokenLife property to org.apache.cxf.rs.security.oauth2.common.Client
> ----------------------------------------------------------------------------------
>
> Key: CXF-4670
> URL: https://issues.apache.org/jira/browse/CXF-4670
> Project: CXF
> Issue Type: Improvement
> Components: JAX-RS Security
> Affects Versions: 2.7.0
> Reporter: Steven Tippetts
> Priority: Minor
>
> I'm currently extending Client to get this property, so it's no big deal for me; however, I'm thinking this may have wider appeal and be a good addition to the library.
> My clients have different token lives so tokenLife helps me keep track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4670) [OAuth2] Add tokenLife property to
org.apache.cxf.rs.security.oauth2.common.Client
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508918#comment-13508918 ]
Sergey Beryozkin commented on CXF-4670:
---------------------------------------
We already have an issuedAt property in AccessToken, can you use it ?
> [OAuth2] Add tokenLife property to org.apache.cxf.rs.security.oauth2.common.Client
> ----------------------------------------------------------------------------------
>
> Key: CXF-4670
> URL: https://issues.apache.org/jira/browse/CXF-4670
> Project: CXF
> Issue Type: Improvement
> Components: JAX-RS Security
> Affects Versions: 2.7.0
> Reporter: Steven Tippetts
> Priority: Minor
>
> I'm currently extending Client to get this property, so it's no big deal for me; however, I'm thinking this may have wider appeal and be a good addition to the library.
> My clients have different token lives so tokenLife helps me keep track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CXF-4670) [OAuth2] Add tokenLife property to
org.apache.cxf.rs.security.oauth2.common.Client
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin resolved CXF-4670.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.7.1
2.6.4
Assignee: Sergey Beryozkin
> [OAuth2] Add tokenLife property to org.apache.cxf.rs.security.oauth2.common.Client
> ----------------------------------------------------------------------------------
>
> Key: CXF-4670
> URL: https://issues.apache.org/jira/browse/CXF-4670
> Project: CXF
> Issue Type: Improvement
> Components: JAX-RS Security
> Affects Versions: 2.7.0
> Reporter: Steven Tippetts
> Assignee: Sergey Beryozkin
> Priority: Minor
> Fix For: 2.6.4, 2.7.1
>
>
> I'm currently extending Client to get this property, so it's no big deal for me; however, I'm thinking this may have wider appeal and be a good addition to the library.
> My clients have different token lives so tokenLife helps me keep track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4670) [OAuth2] Add tokenLife property to
org.apache.cxf.rs.security.oauth2.common.Client
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509686#comment-13509686 ]
Sergey Beryozkin commented on CXF-4670:
---------------------------------------
OK, I'm adding a list of properties to Client too. I'm not sure a specific tokenLife property does belong at the generic model level; what you described makes sense but I wonder if we will have an issue then that some Clients (not necessarily involved in Implicit Grant flow)will want different tokenLife values for different resource endpoints. Hope having a generic list of properties will work for you too
> [OAuth2] Add tokenLife property to org.apache.cxf.rs.security.oauth2.common.Client
> ----------------------------------------------------------------------------------
>
> Key: CXF-4670
> URL: https://issues.apache.org/jira/browse/CXF-4670
> Project: CXF
> Issue Type: Improvement
> Components: JAX-RS Security
> Affects Versions: 2.7.0
> Reporter: Steven Tippetts
> Priority: Minor
>
> I'm currently extending Client to get this property, so it's no big deal for me; however, I'm thinking this may have wider appeal and be a good addition to the library.
> My clients have different token lives so tokenLife helps me keep track of them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira