You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/01/31 13:01:56 UTC

[PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

mbien opened a new pull request, #8216:
URL: https://github.com/apache/netbeans/pull/8216

- added number prefixes for ordering purposes
- added merge/approval checklist to PR template

see below

---
**^Add meaningful description above**

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

### PR approval and merge checklist:

1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien commented on PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#issuecomment-2629039793

> Only the PR change part: I don't think this will help

I am also not sure if this will help but I am out of ideas. The discussion on the mailing list transpired that it might help to have something what reminds devs about those things. I don't see how we can automate this, so lets give the template a try - other apache projects do have this too ([example](https://github.com/apache/maven/blob/master/.github/pull_request_template.md)).

I had enough of having to keep linking the reviewer guide etc - it feels stupid to have to chase after committers and to have to do things like this.

> At least once it was said that the bottom part of the PR should be removed and I agree with that, it should not be part of history or change log.

well. I typically remove it too on my PRs. There are also tricks to open PRs without template, so power users can get a clean slate if they want. This is intended for those who commit once per release or less - or those who keep forgetting how delivery works.

the collapsible section can be also set to auto collapse by manually removing the `open` from `<details open>`, this would add another method to de-noise the PR text as middle ground - if you don't want to remove the whole thing.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien merged PR #8216:
URL: https://github.com/apache/netbeans/pull/8216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.

matthiasblaesing commented on PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#issuecomment-2629021753

   I don't think this will help. People that actually read the text already now the part, because they already know it. At least once it was said that the bottom part of the PR should be removed and I agree with that, it should not be part of history or change log.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien commented on PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#issuecomment-2655271061

   ok lets give this a try. Experienced committers can remove the text or open PRs without a template - same as today. There is also the option to collapse the section by removing the `open` from `<details open>` as middle ground. Those who don't commit often or find the check list useful can use it as reminder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.

neilcsmith-net commented on code in PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#discussion_r1937359068


##########
.github/ISSUE_TEMPLATE/80-config.yml:
##########


Review Comment:
   I'm not sure we should be changing the name of this file!  https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien commented on code in PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#discussion_r1937363936


##########
.github/ISSUE_TEMPLATE/80-config.yml:
##########


Review Comment:
   will revert it back. This means the links will appear at random positions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien commented on PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#issuecomment-2628799670

   we could wrap it in a details section but leave it open by default?
   
   ---
   **^Add meaningful description above**
   
   <details open>
   <summary>Click to collapse PR instructions</summary>
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
   
   ### PR approval and merge checklist:
   
   1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
   2. [x] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
   3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
   3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
   
   If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien commented on code in PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#discussion_r1937367784


##########
.github/ISSUE_TEMPLATE/80-config.yml:
##########


Review Comment:
   it probably will append it to the bottom. reverted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Updated issue templates for NB 25 rc phase + update PR template [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.

mbien commented on PR #8216:
URL: https://github.com/apache/netbeans/pull/8216#issuecomment-2627580499

   just noticed that the checkboxes will be visible as tasks on the PR:
   ![image](https://github.com/user-attachments/assets/8cfcadfa-0f92-4fad-9a04-7b9bb1be90e0)
   
   not sure if we want this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists