[GitHub] [accumulo] keith-turner commented on a diff in pull request #3329: Throw new exception when invalid tablet hosting request made

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3329:
URL: https://github.com/apache/accumulo/pull/3329#discussion_r1174217812


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -213,10 +214,12 @@ Collection<Text> listSplits(String tableName, int maxSplits)
    * @param ranges The input ranges that should be mapped to tablet servers and tablets.
    *
    * @throws TableOfflineException if the table is offline or goes offline during the operation
+   * @throws InvalidTabletHostingRequestException if tablet hosting is requested for table with
+   *         NEVER goal
    * @since 1.8.0
    */
-  Locations locate(String tableName, Collection<Range> ranges)
-      throws AccumuloException, AccumuloSecurityException, TableNotFoundException;

Review Comment:
   Not sure about binary compatibility, but I think adding or removing checked exceptions breaks source compatibility.  So we usually avoid changing them.  Could make this an unchecked exception and declare it in the javadoc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org