[jira] [Updated] (AVRO-1698) cant serialize json with characters >127 when compiling with signed char

["Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thiruvalluvan M. G. updated AVRO-1698:
--------------------------------------
    Resolution: Duplicate
        Status: Resolved  (was: Patch Available)

Fix for AVRO-1190 will automatically take care of this issue.

> cant serialize json with characters >127 when compiling with signed char
> ------------------------------------------------------------------------
>
>                 Key: AVRO-1698
>                 URL: https://issues.apache.org/jira/browse/AVRO-1698
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.7.7
>         Environment: windows, linux w signed char
>            Reporter: svante karlsson
>            Priority: Major
>         Attachments: AVRO-1698.1.patch
>
>
> iscntrl assumes 0-255 but signed char gets expanded to bad things
> pullreq #38  on github solves the issue.
> change line 196 lang/c++/impl/json/JsonIO.hh
> from 
>   if (! iscntrl(*p)) {
> to
>  if (! iscntrl((uint8_t) *p)) {



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)