You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by magiconair <gi...@git.apache.org> on 2014/11/20 22:21:32 UTC

[GitHub] thrift pull request: THRIFT-2796: Added testcase for THRIFT-2793. ...

GitHub user magiconair opened a pull request:

    https://github.com/apache/thrift/pull/278

    THRIFT-2796: Added testcase for THRIFT-2793. Needs testing.

    I've tried compiling thrift tip on OSX Yosemite but I'm getting some compiler errors. Got a vagrant Ubuntu box but have other issues getting the build off the ground. 
    
    Maybe someone else can review the test case?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/magiconair/thrift THRIFT-2796

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #278
    
----
commit d131a5c165c7b198d3c85be7d0db68670e499eda
Author: Frank Schroeder <fr...@ebay.com>
Date:   2014-11-20T21:03:53Z

    THRIFT-2796: Added testcase for THRIFT-2793. Needs testing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #278: THRIFT-2796: Added testcase for THRIFT-2793. Needs testin...

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/278
  
    @jfarrell this can be closed.  It was resolved incomplete/later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #278: THRIFT-2796: Added testcase for THRIFT-2793. Needs...

Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell closed the pull request at:

    https://github.com/apache/thrift/pull/278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---