[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #23471: Add RQL parser test case for `mask rule`

[GitBox <gi...@apache.org>]

Qianyi951015 opened a new pull request, #23471:
URL: https://github.com/apache/shardingsphere/pull/23471

   
   Changes proposed in this pull request:
     - add `show mask rules` case
     - add `count mask rule` case
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #23471: Add RQL parser test case for `mask rule`

[GitBox <gi...@apache.org>]

RaigorJiang commented on code in PR #23471:
URL: https://github.com/apache/shardingsphere/pull/23471#discussion_r1065464061


##########
test/it/parser/src/main/resources/case/rql/show.xml:
##########
@@ -107,6 +107,10 @@
         <database name="sharding_db" start-index="36" stop-index="46" />
     </show-default-sharding-strategy>
     
+    <show-default-sharding-strategy sql-case-id="show-mask-rules">

Review Comment:
   `show-default-sharding-strategy` is not right for here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang merged pull request #23471: Add RQL parser test case for `mask rule`

[GitBox <gi...@apache.org>]

RaigorJiang merged PR #23471:
URL: https://github.com/apache/shardingsphere/pull/23471


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org