You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/12/02 08:06:25 UTC

[GitHub] [shenyu] tian-pengfei commented on pull request #4232: [type:refactor] tidied up Utils.

tian-pengfei commented on PR #4232:
URL: https://github.com/apache/shenyu/pull/4232#issuecomment-1334883823

   > Will this modification cause old users to fail to log in?
   > 
   > Have you had any tests?
   
   no funtion change 
   DigestUtils.sha512Hex == ShaUtils.shaEncryption
   Md5Utils.md5 == DigestUtils.md5Hex
   
   see DigestUtilsTest.java
   ![image](https://user-images.githubusercontent.com/42602026/205244849-bb55ae97-2b84-4486-8692-28550cac54d2.png)
   
   old md5 test 
   ![image](https://user-images.githubusercontent.com/42602026/205245020-6211662b-9318-4c69-9e51-bc0fe183aaa5.png)
   
   test same as before, no funtion change 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org