You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ericm-db (via GitHub)" <gi...@apache.org> on 2025/08/12 00:47:15 UTC
[PR] [wip] Split job [spark]
ericm-db opened a new pull request, #51982:
URL: https://github.com/apache/spark/pull/51982
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #51982:
URL: https://github.com/apache/spark/pull/51982#issuecomment-3180165624
> Ah okay, this is concerning then. Let me look closer into this. I wonder if we are making a bad call to RocksDB that is triggering this?
Thank you ~ I share that concern too, but I haven't found any evidence yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #51982:
URL: https://github.com/apache/spark/pull/51982#issuecomment-3180123263
Actually, at first I also thought it was a test timeout, but after further investigation, I found that wasn't the case. From the link you provided, we can click the `view raw log` button to jump to the raw log, where we can see the following log entries:
- https://github.com/bothra90/spark/actions/runs/16890007851/job/47847187857
- https://productionresultssa17.blob.core.windows.net/actions-results/503f3eff-310b-4318-baf1-05bb09b4c767/workflow-job-run-cd4a0ec5-046b-5e46-bf3d-5275fd324cde/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-08-12T16%3A23%3A55Z&sig=ZeCDltw1656cFR0hprOSzNtfxPUsYaRZNisojapREO0%3D&ske=2025-08-13T02%3A05%3A47Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-08-12T14%3A05%3A47Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-05-05&sp=r&spr=https&sr=b&st=2025-08-12T16%3A13%3A50Z&sv=2025-05-05
```
2025-08-11T20:35:52.1545306Z # If you would like to submit a bug report, please visit:
2025-08-11T20:35:52.1546207Z # http://www.azul.com/support/
2025-08-11T20:35:52.1546675Z # The crash happened outside the Java Virtual Machine in native code.
2025-08-11T20:35:52.1547085Z # See problematic frame for where to report the bug.
2025-08-11T20:35:52.1547369Z #
2025-08-11T20:36:50.1651953Z Warning: Unable to read from client, please check on client for further details of the problem.
2025-08-11T21:26:57.0049131Z
2025-08-11T21:26:59.0048819Z Session terminated, killing shell... ...killed.
2025-08-11T21:26:59.0566823Z ##[error]The operation was canceled.
2025-08-11T21:26:59.0899479Z ##[group]Run actions/upload-artifact@v4
```
From the logs, we can observe the following:
1. At 2025-08-11T20:35:52, RocksDB crashed.
2. At 2025-08-11T21:26:59, the current GitHub Action Task for the test was terminated.
Between 2025-08-11T20:35:52 and 2025-08-11T21:26:59, only one log entry was printed: `Warning: Unable to read from client, please check on client for further details of the problem.` No other test cases were executed during this period. Therefore, I believe that after the RocksDB crash, the entire testing process became stuck until the test task timed out, and this timeout was triggered by the RocksDB crash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #51982:
URL: https://github.com/apache/spark/pull/51982#discussion_r2270522254
##########
.github/workflows/build_and_test.yml:
##########
@@ -378,7 +387,24 @@ jobs:
MODULES_TO_TEST=${MODULES_TO_TEST//streaming-kinesis-asl, /}
fi
export SERIAL_SBT_TESTS=1
- ./dev/run-tests --parallelism 1 --modules "$MODULES_TO_TEST" --included-tags "$INCLUDED_TAGS" --excluded-tags "$EXCLUDED_TAGS"
+
+ if [[ "$TEST_SPLIT" != "" && "$INCLUDED_TAGS" == *"SlowSQLTest"* ]]; then
+ # Split SlowSQLTest classes alphabetically using SBT testOnly
+ SLOW_SQL_CLASSES=$(find . -name "*.scala" -exec grep -l "@SlowSQLTest" {} \; | sed 's|.*/||' | sed 's|\.scala||' | sort)
+ TOTAL_CLASSES=$(echo "$SLOW_SQL_CLASSES" | wc -l)
+ HALF=$((TOTAL_CLASSES / 2))
+
+ if [[ "$TEST_SPLIT" == "part1" ]]; then
+ TEST_CLASSES=$(echo "$SLOW_SQL_CLASSES" | head -n $HALF | paste -sd ',' -)
Review Comment:
Looking solely at the code, there are two issues here:
1. The result of `TEST_CLASSES` is `AcceptsLatestSeenOffsetSuite,AdaptiveQueryExecSuite,AggregateHashMapSuite,AllExecutionsPageSuite,...`, but in reality, they should be `*AcceptsLatestSeenOffsetSuite,*AdaptiveQueryExecSuite,*AggregateHashMapSuite,*AllExecutionsPageSuite,...`，so none of the tests are being executed at all now.
- https://github.com/ericm-db/spark/actions/runs/16895995712/job/47867693939
3. Some test case names are incorrect. For example, `AggregateHashMapSuite.scala` contains three `SlowSQLTest`s: `SingleLevelAggregateHashMapSuite`, `TwoLevelAggregateHashMapSuite`, and `TwoLevelAggregateHashMapWithVectorizedMapSuite`. Even if `*AggregateHashMapSuite` is executed, it will not trigger valid tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on PR #51982:
URL: https://github.com/apache/spark/pull/51982#issuecomment-3180157931
Ah okay, this is concerning then. Let me look closer into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db closed pull request #51982: [wip] Split job
URL: https://github.com/apache/spark/pull/51982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on PR #51982:
URL: https://github.com/apache/spark/pull/51982#issuecomment-3180110586
@LuciferYang This is the PR I've written to try to address the long job runtime of 'sql - slow tests'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #51982:
URL: https://github.com/apache/spark/pull/51982#discussion_r2270531121
##########
.github/workflows/build_and_test.yml:
##########
@@ -378,7 +387,24 @@ jobs:
MODULES_TO_TEST=${MODULES_TO_TEST//streaming-kinesis-asl, /}
fi
export SERIAL_SBT_TESTS=1
- ./dev/run-tests --parallelism 1 --modules "$MODULES_TO_TEST" --included-tags "$INCLUDED_TAGS" --excluded-tags "$EXCLUDED_TAGS"
+
+ if [[ "$TEST_SPLIT" != "" && "$INCLUDED_TAGS" == *"SlowSQLTest"* ]]; then
+ # Split SlowSQLTest classes alphabetically using SBT testOnly
+ SLOW_SQL_CLASSES=$(find . -name "*.scala" -exec grep -l "@SlowSQLTest" {} \; | sed 's|.*/||' | sed 's|\.scala||' | sort)
+ TOTAL_CLASSES=$(echo "$SLOW_SQL_CLASSES" | wc -l)
+ HALF=$((TOTAL_CLASSES / 2))
+
+ if [[ "$TEST_SPLIT" == "part1" ]]; then
+ TEST_CLASSES=$(echo "$SLOW_SQL_CLASSES" | head -n $HALF | paste -sd ',' -)
Review Comment:
Haha yeah I realized this too - I was going to do a grep for @SQLSlowTest, look at the class name (discard any abstract classes) and then run those with "*" prepended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [wip] Split job [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #51982:
URL: https://github.com/apache/spark/pull/51982#discussion_r2270522254
##########
.github/workflows/build_and_test.yml:
##########
@@ -378,7 +387,24 @@ jobs:
MODULES_TO_TEST=${MODULES_TO_TEST//streaming-kinesis-asl, /}
fi
export SERIAL_SBT_TESTS=1
- ./dev/run-tests --parallelism 1 --modules "$MODULES_TO_TEST" --included-tags "$INCLUDED_TAGS" --excluded-tags "$EXCLUDED_TAGS"
+
+ if [[ "$TEST_SPLIT" != "" && "$INCLUDED_TAGS" == *"SlowSQLTest"* ]]; then
+ # Split SlowSQLTest classes alphabetically using SBT testOnly
+ SLOW_SQL_CLASSES=$(find . -name "*.scala" -exec grep -l "@SlowSQLTest" {} \; | sed 's|.*/||' | sed 's|\.scala||' | sort)
+ TOTAL_CLASSES=$(echo "$SLOW_SQL_CLASSES" | wc -l)
+ HALF=$((TOTAL_CLASSES / 2))
+
+ if [[ "$TEST_SPLIT" == "part1" ]]; then
+ TEST_CLASSES=$(echo "$SLOW_SQL_CLASSES" | head -n $HALF | paste -sd ',' -)
Review Comment:
Looking solely at the code, there are two issues here:
1. The result of `TEST_CLASSES` is `AcceptsLatestSeenOffsetSuite,AdaptiveQueryExecSuite,AggregateHashMapSuite,AllExecutionsPageSuite,...`, but in reality, they should be `*AcceptsLatestSeenOffsetSuite *AdaptiveQueryExecSuite *AggregateHashMapSuite,*AllExecutionsPageSuite,...`，so none of the tests are being executed at all now.
- https://github.com/ericm-db/spark/actions/runs/16895995712/job/47867693939
3. Some test case names are incorrect. For example, `AggregateHashMapSuite.scala` contains three `SlowSQLTest`s: `SingleLevelAggregateHashMapSuite`, `TwoLevelAggregateHashMapSuite`, and `TwoLevelAggregateHashMapWithVectorizedMapSuite`. Even if `*AggregateHashMapSuite` is executed, it will not trigger valid tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org