You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/05/30 02:58:19 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #257: HBASE-22463 Some paths in HFileScannerImpl did not consider block#release which will exhaust the ByteBuffAllocator

Apache9 commented on a change in pull request #257: HBASE-22463 Some paths in HFileScannerImpl did not consider block#release which will exhaust the ByteBuffAllocator
URL: https://github.com/apache/hbase/pull/257#discussion_r288841411
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Cacheable.java
 ##########
 @@ -63,20 +63,6 @@
    */
   BlockType getBlockType();
 
-  /**
-   * @return the {@code MemoryType} of this Cacheable
-   */
-  MemoryType getMemoryType();
 
 Review comment:
   OK, so now we can hide this detail to upper layer. Good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services