You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:19:40 UTC
[GitHub] [tvm] NicolaLancellotti commented on a diff in pull request #13656: [CMSIS-NN] Support CMSIS NN from new GitHub location
NicolaLancellotti commented on code in PR #13656:
URL: https://github.com/apache/tvm/pull/13656#discussion_r1064885657
##########
tests/micro/zephyr/test_zephyr.py:
##########
@@ -623,7 +624,7 @@ def test_schedule_build_with_cmsis_dependency(workspace_dir, board, microtvm_deb
assert "CMSIS/DSP/Include" in cmake_content
assert "CMSIS/DSP/Include/dsp" in cmake_content
assert "CMSIS/DSP/Include" in cmake_content
- assert "CMSIS/NN/Include" in cmake_content
+ # assert "CMSIS-NN/Include" in cmake_content
Review Comment:
In the future, after the docker image will be updated, we want this assert.
##########
docker/install/ubuntu_install_ethosu_driver_stack.sh:
##########
@@ -85,6 +85,9 @@ cmake -DCMAKE_TOOLCHAIN_FILE=${ethosu_dir}/core_platform/cmake/toolchain/arm-non
make
# Build NN Library
+mkdir ${CMSIS_PATH}/CMSIS-NN/build/ && cd ${CMSIS_PATH}/CMSIS-NN/build/
+cmake .. -DCMAKE_TOOLCHAIN_FILE=${ethosu_dir}/core_platform/cmake/toolchain/arm-none-eabi-gcc.cmake -DTARGET_CPU=cortex-m55 -DBUILD_CMSIS_NN_FUNCTIONS=YES -DCMSIS_PATH=${CMSIS_PATH}
+
mkdir ${CMSIS_PATH}/CMSIS/NN/build/ && cd ${CMSIS_PATH}/CMSIS/NN/build/
cmake .. -DCMAKE_TOOLCHAIN_FILE=${ethosu_dir}/core_platform/cmake/toolchain/arm-none-eabi-gcc.cmake -DTARGET_CPU=cortex-m55 -DBUILD_CMSIS_NN_FUNCTIONS=YES
make
Review Comment:
The first one builds the new `CMSIS-NN`, and the second one builds the old `CMSIS/NN`.
When the docker image will be updated I'll remove support for `CMSIS/NN`, that is, I''ll revert this commit: https://github.com/apache/tvm/pull/13656/commits/ff57097856d7e100fbace341c3ac528ffe52acfa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org