You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/07/27 22:05:14 UTC
[jira] Created: (CASSANDRA-319) trivial bug in UTF8Type
trivial bug in UTF8Type
-----------------------
Key: CASSANDRA-319
URL: https://issues.apache.org/jira/browse/CASSANDRA-319
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.4
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
comparing X to [] where X is not [] should be 1, not -1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-319) trivial bug in Marshal
comparators
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735753#action_12735753 ]
Jonathan Ellis commented on CASSANDRA-319:
------------------------------------------
committed with comment to AbstractType:
* Note that empty byte[] are used to represent "start at the beginning"
* or "stop at the end" arguments to get_slice, so the Comparator
* should always handle those values even if they normally do not
* represent a valid byte[] for the type being compared.
> trivial bug in Marshal comparators
> ----------------------------------
>
> Key: CASSANDRA-319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-319
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 319.patch
>
>
> comparing X to [] where X is not [] should be 1, not -1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-319) trivial bug in UTF8Type
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-319:
-------------------------------------
Attachment: 319.patch
this patch also:
removes special-casing of [] in UTF8, since [] already deserializes to ""
removes TODOs hoping to r/m special-casing []; we'll always need that to support slice/finish sentinel values in get_slice
> trivial bug in UTF8Type
> -----------------------
>
> Key: CASSANDRA-319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-319
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 319.patch
>
>
> comparing X to [] where X is not [] should be 1, not -1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-319) trivial bug in Marshal
comparators
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735750#action_12735750 ]
Stu Hood commented on CASSANDRA-319:
------------------------------------
Assuming that it passes the rest of the unit tests, this patch looks alright. But rather than removing the TODOs, I would turn them into comments, since they document confusing behaviour.
> trivial bug in Marshal comparators
> ----------------------------------
>
> Key: CASSANDRA-319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-319
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 319.patch
>
>
> comparing X to [] where X is not [] should be 1, not -1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-319) trivial bug in Marshal comparators
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-319.
--------------------------------------
Resolution: Fixed
committed
> trivial bug in Marshal comparators
> ----------------------------------
>
> Key: CASSANDRA-319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-319
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 319.patch
>
>
> comparing X to [] where X is not [] should be 1, not -1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-319) trivial bug in Marshal comparators
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-319:
-------------------------------------
Summary: trivial bug in Marshal comparators (was: trivial bug in UTF8Type)
> trivial bug in Marshal comparators
> ----------------------------------
>
> Key: CASSANDRA-319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-319
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 319.patch
>
>
> comparing X to [] where X is not [] should be 1, not -1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.