[GitHub] [bookkeeper] pkumar-singh commented on a change in pull request #2812: ISSUE #2640: BP-43 Migrate to gradle all other tests

[GitBox <gi...@apache.org>]

pkumar-singh commented on a change in pull request #2812:
URL: https://github.com/apache/bookkeeper/pull/2812#discussion_r732075881



##########
File path: .github/workflows/pr-validation.yml
##########
@@ -48,7 +46,7 @@ jobs:
         uses: actions/setup-java@v1
         with:
           java-version: 1.8
-      - name: Validate pull request style
-        run: mvn clean -B -nsu apache-rat:check checkstyle:check package -Ddistributedlog -DskipTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO

Review comment:
       Hello @eolivelli. Actually it does run rat. For instance take a look at the output. 
   If you see in PR validations command is this.
   ./gradlew build -x microbenchmarks:checkstyleMain -x spotbugsTest -x signDistTar -x test
   It essentially means gradle will run all the tasks except spot bugs for the test code, running tests, signing dist tar ball checkstyle of microbenchmarks. That means it runs rat, checkStyle for source code, spot bug for source code. 
   
   I would like to extend  it to run spot bugs as well as check style for test code as well. But that would require code change. 
   
   RAT Plugin output of this PR: https://github.com/apache/bookkeeper/pull/2812/checks?check_run_id=3931457644#step:5:343




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org