You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/28 13:29:00 UTC
[jira] [Commented] (ARTEMIS-1308) Client Acknowledge not performant
[ https://issues.apache.org/jira/browse/ARTEMIS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16104941#comment-16104941 ]
ASF GitHub Bot commented on ARTEMIS-1308:
-----------------------------------------
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1425
ARTEMIS-1308: Delegate acknowlegde to ClientMessage
ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1308
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1425
----
commit 676d2cdd7c0c7184c2828a2e07d431793b559ad7
Author: Michael Andre Pearce <mi...@me.com>
Date: 2017-07-28T13:27:29Z
ARTEMIS-1308: Delegate acknowlegde to ClientMessage
ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge
----
> Client Acknowledge not performant
> ---------------------------------
>
> Key: ARTEMIS-1308
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1308
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Michael Andre Pearce
>
> Artemis recommendation in docs is to use CLIENT_ACKNOWLEDGE instead of AUTO_ACKNOWLEDGE, on perf testing it seems this is not the case.
> On checking code it seems the reason for this is because ActiveMQMessage acknowledge actually calls session.commit, causing a full session commit all the time.
> On checking Core API, calling message.acknowledge it seems to behave as expected, as such believe this to be an issue in JMS api wrapper, that it should just be delegating to the ClientMessage.acknowledge method and this is the cause of the perf issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)