You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aprimadi (via GitHub)" <gi...@apache.org> on 2023/06/22 19:27:20 UTC
[GitHub] [arrow-datafusion] aprimadi opened a new pull request, #6750: Use JoinSet in MemTable
aprimadi opened a new pull request, #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750
# Which issue does this PR close?
Closes #6513
# Rationale for this change
N/A
# What changes are included in this PR?
TODO
# Are these changes tested?
TODO
# Are there any user-facing changes?
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] aprimadi commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "aprimadi (via GitHub)" <gi...@apache.org>.
aprimadi commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1622080578
Thank you @crepererum and @alamb for the review. Sorry I haven't succeed in refactoring RepartitionExec been kinda busy.
I may try again once I have quite a large chunk of development and debugging time to tackle it. Or I may also not be able to do it at all due to not having enough skill 😜.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] aprimadi commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "aprimadi (via GitHub)" <gi...@apache.org>.
aprimadi commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1604563358
Sorry this is going to take a while @alamb I'm a bit busy these last few weeks. Will work on this whenever I have some free hours.
Feel free to let me know if you need to get this done quickly and I'll get it to a reviewable state and mark it as ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1608098043
> Feel free to let me know if you need to get this done quickly and I'll get it to a reviewable state and mark it as ready for review.
No problem @aprimadi -- we really appreciate all the help! In order to avoid this PR bitrotting, perhaps you could get it to a reviewable state (even if it doesn't port all of the uses) and we can merge that as you work on the other uses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1622058525
Thank you @aprimadi and @crepererum ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1619031194
> I haven't succeed in refactoring RepartitionExec to use JoinSet.
That is likely the most tricky one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1604402421
Thank you @aprimadi (cc @crepererum )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] aprimadi commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "aprimadi (via GitHub)" <gi...@apache.org>.
aprimadi commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1617729612
I haven't succeed in refactoring RepartitionExec to use JoinSet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] crepererum commented on pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750#issuecomment-1620205194
> I haven't succeed in refactoring RepartitionExec to use JoinSet.
That's OK, I've added a subtask to #6513 so we can do that in a follow-up. Let's merge this PR here so it doesn't get stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] crepererum merged pull request #6750: Replace AbortOnDrop / AbortDropOnMany with tokio JoinSet
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum merged PR #6750:
URL: https://github.com/apache/arrow-datafusion/pull/6750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org