You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "polandll (via GitHub)" <gi...@apache.org> on 2023/10/17 22:08:24 UTC
[PR] Add reference commands [cassandra]
polandll opened a new pull request, #2815:
URL: https://github.com/apache/cassandra/pull/2815
Reference CQL commands that will be referenced in the CEP-30 Vector Search PR. I did not create a ticket for this work.
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add reference commands [cassandra]
Posted by "polandll (via GitHub)" <gi...@apache.org>.
polandll commented on code in PR #2815:
URL: https://github.com/apache/cassandra/pull/2815#discussion_r1369081035
##########
doc/modules/cassandra/pages/reference/index.adoc:
##########
@@ -1,4 +1,3 @@
= Reference
-* xref:cassandra:reference/cql-commands/commands-toc.adoc[CQL commands]
-* xref:cassandra:reference/java17.adoc[Java 17 usage]
\ No newline at end of file
+* xref:reference/cql-commands/commands-toc.adoc[CQL commands]
Review Comment:
I did not intend to delete java17.adoc link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add reference commands [cassandra]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2815:
URL: https://github.com/apache/cassandra/pull/2815#discussion_r1368549443
##########
doc/modules/cassandra/pages/reference/index.adoc:
##########
@@ -1,4 +1,3 @@
= Reference
-* xref:cassandra:reference/cql-commands/commands-toc.adoc[CQL commands]
-* xref:cassandra:reference/java17.adoc[Java 17 usage]
\ No newline at end of file
+* xref:reference/cql-commands/commands-toc.adoc[CQL commands]
Review Comment:
intended to remove java17.adoc link ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add reference commands [cassandra]
Posted by "polandll (via GitHub)" <gi...@apache.org>.
polandll commented on code in PR #2815:
URL: https://github.com/apache/cassandra/pull/2815#discussion_r1369081239
##########
doc/modules/cassandra/pages/reference/cql-commands/commands-toc.adoc:
##########
Review Comment:
Yes, they will be added over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add reference commands [cassandra]
Posted by "polandll (via GitHub)" <gi...@apache.org>.
polandll closed pull request #2815: Add reference commands
URL: https://github.com/apache/cassandra/pull/2815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Add reference commands [cassandra]
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2815:
URL: https://github.com/apache/cassandra/pull/2815#discussion_r1368549974
##########
doc/modules/cassandra/pages/reference/cql-commands/commands-toc.adoc:
##########
Review Comment:
lots of commented out xref lines in this file, is that intended ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org