You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/15 22:33:01 UTC
[GitHub] [beam] apilloud commented on a change in pull request #14241: [BEAM-11747] Narrow list of unsupported types in BeamJavaUdfCalcRule.
apilloud commented on a change in pull request #14241:
URL: https://github.com/apache/beam/pull/14241#discussion_r594728310
##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -174,29 +174,20 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x) {
} else if (rexNode instanceof RexLiteral) {
SqlTypeName typeName = ((RexLiteral) rexNode).getTypeName();
switch (typeName) {
- case NULL:
- case BOOLEAN:
- case CHAR:
- case BINARY:
- case DECIMAL:
- break;
- default:
- // Reject unsupported literals
+ case BIGINT: // BEAM-11989
+ case DATE: // BEAM-11990
return false;
+ default:
+ break;
}
} else if (rexNode instanceof RexInputRef) {
SqlTypeName typeName = ((RexInputRef) rexNode).getType().getSqlTypeName();
switch (typeName) {
- case BIGINT:
- case DOUBLE:
- case BOOLEAN:
- case VARCHAR:
- case VARBINARY:
- case DECIMAL:
- break;
- default:
- // Reject unsupported input ref
+ case BIGINT: // BEAM-11989
Review comment:
BigInt was actually in the supported types for InputRef before...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org