You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:46:20 UTC
[GitHub] [druid] mitchlloyd opened a new pull request #10218: Allow STS regional endpoints
mitchlloyd opened a new pull request #10218:
URL: https://github.com/apache/druid/pull/10218
### Description
This change allows Druid users to configure a regional endpoint for STS in their Kinesis ingest specs. Configuring a regional endpoint rather than using the default global endpoint is [recommended by AWS](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_enable-regions.html). This is also an internal requirement for running our Druid cluster.
I added an optional `awsStsEndpoint` configuration value to the `KinesisIndexTaskIOConfig` class. When this value is present, the `AWSSecurityTokenServiceClientBuilder` has endpoint configuration applied.
I picked the name `awsStsEndpoint` to align with the existing configuration values `awsAssumedRoleArn` and `awsExternalId`.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `KinesisIndexTaskIOConfig`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mitchlloyd closed pull request #10218: Allow STS regional endpoints
Posted by GitBox <gi...@apache.org>.
mitchlloyd closed pull request #10218:
URL: https://github.com/apache/druid/pull/10218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mitchlloyd edited a comment on pull request #10218: Allow STS regional endpoints
Posted by GitBox <gi...@apache.org>.
mitchlloyd edited a comment on pull request #10218:
URL: https://github.com/apache/druid/pull/10218#issuecomment-686753739
I paused this work because it turns out that there is an environment variable that one can set to use regional endpoints: `AWS_STS_REGIONAL_ENDPOINTS`. However that environment variable [only works with the AWS SDK 1.11.658 or later](https://github.com/aws/aws-sdk-java/issues/2362#issuecomment-647835178) and Druid is using 1.11.199. Are there any known obstacles to updating the AWS SDK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mitchlloyd commented on pull request #10218: Allow STS regional endpoints
Posted by GitBox <gi...@apache.org>.
mitchlloyd commented on pull request #10218:
URL: https://github.com/apache/druid/pull/10218#issuecomment-689729946
Closing this PR and opening an issue for an SDK upgrade.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mitchlloyd commented on pull request #10218: Allow STS regional endpoints
Posted by GitBox <gi...@apache.org>.
mitchlloyd commented on pull request #10218:
URL: https://github.com/apache/druid/pull/10218#issuecomment-686753739
I paused this work because it turns out that there is an environment variable that one can set to use regional endpoints: `AWS_STS_REGIONAL_ENDPOINTS`. However that environment variable only works with the AWS SDK 1.11.658 or later and Druid is using 1.11.199. Are there any known obstacles to updating the AWS SDK?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org