[GitHub] [solr] risdenk commented on a diff in pull request #1363: SOLR-16664: TestCoordinatorRole fails docs is null

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on code in PR #1363:
URL: https://github.com/apache/solr/pull/1363#discussion_r1109878584


##########
solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java:
##########
@@ -389,6 +390,7 @@ private String getHostCoreName(
     SolrQuery q = new SolrQuery("*:*");
     q.add("fl", "id,desc_s,_core_:[core]").add(OMIT_HEADER, TRUE);
     p.accept(q);
+    // TODO why is this building a string instead of using the proper SolrClient???

Review Comment:
   I don't understand what you mean. I pushed up ff1f547eada49b494f5943ff2bb0e95ef3f4a671 which does exactly what I said using SolrClient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org