You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/02/07 09:29:46 UTC
Review Request 56377: Log Search should use Credential Store API to
store keystore/truststore passwords - ambari side
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi Radhakrishnan, Oliver Szabo, and Robert Nettleton.
Bugs: AMBARI-19645
https://issues.apache.org/jira/browse/AMBARI-19645
Repository: ambari
Description
-------
Ambari modifications to enforce Log Search + Log Feeder to use the Credential Store API to store keystore/truststore passwords.
Diffs
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 508ef4e
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 10b21be
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 2b95b78
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 08c0a7b
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py a04618f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 08d3d9d
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 1c79c5c
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f63cd42
Diff: https://reviews.apache.org/r/56377/diff/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely
Re: Review Request 56377: Log Search should use Credential Store API
to store keystore/truststore passwords - ambari side
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164532
-----------------------------------------------------------
Ship it!
- Madhuvanthi Radhakrishnan
On Feb. 7, 2017, 4:12 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56377/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 4:12 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi Radhakrishnan, Oliver Szabo, and Robert Nettleton.
>
>
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari modifications to enforce Log Search + Log Feeder to use the Credential Store API to store keystore/truststore passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 508ef4e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 10b21be
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 2b95b78
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 08c0a7b
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py a04618f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 08d3d9d
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 1c79c5c
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f63cd42
>
> Diff: https://reviews.apache.org/r/56377/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56377: Log Search should use Credential Store API
to store keystore/truststore passwords - ambari side
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164570
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Feb. 7, 2017, 4:12 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56377/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 4:12 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi Radhakrishnan, Oliver Szabo, and Robert Nettleton.
>
>
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari modifications to enforce Log Search + Log Feeder to use the Credential Store API to store keystore/truststore passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 508ef4e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 10b21be
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 2b95b78
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 08c0a7b
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py a04618f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 08d3d9d
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 1c79c5c
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f63cd42
>
> Diff: https://reviews.apache.org/r/56377/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56377: Log Search should use Credential Store API
to store keystore/truststore passwords - ambari side
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164715
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Feb. 7, 2017, 4:12 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56377/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 4:12 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi Radhakrishnan, Oliver Szabo, and Robert Nettleton.
>
>
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari modifications to enforce Log Search + Log Feeder to use the Credential Store API to store keystore/truststore passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 508ef4e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 10b21be
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 2b95b78
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 08c0a7b
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py a04618f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 08d3d9d
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 1c79c5c
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f63cd42
>
> Diff: https://reviews.apache.org/r/56377/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56377: Log Search should use Credential Store API
to store keystore/truststore passwords - ambari side
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/#review164522
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Feb. 7, 2017, 4:12 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56377/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 4:12 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi Radhakrishnan, Oliver Szabo, and Robert Nettleton.
>
>
> Bugs: AMBARI-19645
> https://issues.apache.org/jira/browse/AMBARI-19645
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari modifications to enforce Log Search + Log Feeder to use the Credential Store API to store keystore/truststore passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 508ef4e
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 10b21be
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 2b95b78
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 08c0a7b
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py a04618f
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 08d3d9d
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 1c79c5c
> ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f63cd42
>
> Diff: https://reviews.apache.org/r/56377/diff/
>
>
> Testing
> -------
>
> Tested on local cluster.
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56377: Log Search should use Credential Store API
to store keystore/truststore passwords - ambari side
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56377/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 4:12 p.m.)
Review request for Ambari, Andrew Onischuk, Jayush Luniya, Madhuvanthi Radhakrishnan, Oliver Szabo, and Robert Nettleton.
Changes
-------
Rename jceks files, remove -env from their names.
Bugs: AMBARI-19645
https://issues.apache.org/jira/browse/AMBARI-19645
Repository: ambari
Description
-------
Ambari modifications to enforce Log Search + Log Feeder to use the Credential Store API to store keystore/truststore passwords.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 508ef4e
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 10b21be
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 2b95b78
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 08c0a7b
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py a04618f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py 08d3d9d
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 1c79c5c
ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py f63cd42
Diff: https://reviews.apache.org/r/56377/diff/
Testing
-------
Tested on local cluster.
Thanks,
Miklos Gergely