[jira] [Commented] (FLINK-9018) Unclosed snapshotCloseableRegistry in RocksDBKeyedStateBackend#FullSnapshotStrategy#performSnapshot

["Sihua Zhou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404577#comment-16404577 ] 

Sihua Zhou commented on FLINK-9018:
-----------------------------------

Hi [~yuzhihong@gmail.com], why this should be a bug? I think {{snapshotCloseableRegistry}} will be empty in this case, so it doesn't need to be closed...

> Unclosed snapshotCloseableRegistry in RocksDBKeyedStateBackend#FullSnapshotStrategy#performSnapshot
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-9018
>                 URL: https://issues.apache.org/jira/browse/FLINK-9018
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>       final CloseableRegistry snapshotCloseableRegistry = new CloseableRegistry();
>       if (kvStateInformation.isEmpty()) {
>         if (LOG.isDebugEnabled()) {
>           LOG.debug("Asynchronous RocksDB snapshot performed on empty keyed state at {}. Returning null.",
>             timestamp);
>         }
>         return DoneFuture.of(SnapshotResult.empty());
>       }
> {code}
> If the method returns in the above if block, snapshotCloseableRegistry is not closed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)