You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/06/25 22:08:03 UTC
[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2
Hello Alexey Serbin, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13729
to review the following change.
Change subject: thirdparty: fix build-if-necessary in tarballs pt 2
......................................................................
thirdparty: fix build-if-necessary in tarballs pt 2
This is a follow-up to 428d175 to use `find` instead of `grep` since
`grep` returns an exit code of 1 when the results set is empty.
Without this, I couldn't build 1.10.0 RC2 since build-if-necessary.sh
would exit with 1.
Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
---
M thirdparty/build-if-necessary.sh
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/13729/1
--
To view, visit http://gerrit.cloudera.org:8080/13729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13729 )
Change subject: thirdparty: fix build-if-necessary in tarballs pt 2
......................................................................
thirdparty: fix build-if-necessary in tarballs pt 2
This is a follow-up to 428d175 to use `find` instead of `grep` since
`grep` returns an exit code of 1 when the results set is empty.
Without this, I couldn't build 1.10.0 RC2 since build-if-necessary.sh
would exit with 1.
Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Reviewed-on: http://gerrit.cloudera.org:8080/13729
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/build-if-necessary.sh
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 )
Change subject: thirdparty: fix build-if-necessary in tarballs pt 2
......................................................................
Patch Set 1: -Code-Review
Ah nevermind, I was confused because it said that build-if-necessary.sh had changed. Low and behold, I'd changed build-if-necessary.sh :)
--
To view, visit http://gerrit.cloudera.org:8080/13729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:13:09 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 )
Change subject: thirdparty: fix build-if-necessary in tarballs pt 2
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:15:32 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 )
Change subject: thirdparty: fix build-if-necessary in tarballs pt 2
......................................................................
Patch Set 1: Code-Review-2
Hrm, hang on, I'm looking into this a bit more. Seems it might not be quite right yet.
--
To view, visit http://gerrit.cloudera.org:8080/13729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:12:18 +0000
Gerrit-HasComments: No
[kudu-CR] thirdparty: fix build-if-necessary in tarballs pt 2
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13729 )
Change subject: thirdparty: fix build-if-necessary in tarballs pt 2
......................................................................
Patch Set 1: Code-Review+2
Woops, sorry!
--
To view, visit http://gerrit.cloudera.org:8080/13729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8ffbd69c3622669b73500efaacd4f4e21cfa77a
Gerrit-Change-Number: 13729
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 25 Jun 2019 22:11:40 +0000
Gerrit-HasComments: No